Skip to content

Fail Sentry DIF uploads loudly after bounded retries #15819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
warp-agent-staging wants to merge 1 commit into
base: master
Choose a base branch
from
+33 −7
Open

Fail Sentry DIF uploads loudly after bounded retries #15819

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 33 additions & 7 deletions script/sentry_upload_dif.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,37 @@

set -x

if which sentry-cli >/dev/null; then
ERROR="$(sentry-cli upload-dif "$DEBUG_FILE_OR_FOLDER_PATH")"
if [ ! $? -eq 0 ]; then
echo "warning: sentry-cli - $ERROR"
fi
else
echo "warning: sentry-cli not installed, download from https://github.com/getsentry/sentry-cli/releases"
MAX_ATTEMPTS=3
INITIAL_RETRY_DELAY_SECONDS=5
MAX_RETRY_DELAY_SECONDS=10

if ! command -v sentry-cli >/dev/null; then
echo "::error title=Error uploading Sentry debug files::sentry-cli not installed, download from https://github.com/getsentry/sentry-cli/releases"
exit 1
fi

if [ ! -e "$DEBUG_FILE_OR_FOLDER_PATH" ]; then
echo "::error title=Error uploading Sentry debug files::DEBUG_FILE_OR_FOLDER_PATH '$DEBUG_FILE_OR_FOLDER_PATH' does not exist"
exit 1
fi

attempt=1
retry_delay_seconds=$INITIAL_RETRY_DELAY_SECONDS
while true; do
if sentry-cli upload-dif "$DEBUG_FILE_OR_FOLDER_PATH"; then
echo "Sentry debug file upload succeeded on attempt $attempt/$MAX_ATTEMPTS."
exit 0
fi

if [ "$attempt" -ge "$MAX_ATTEMPTS" ]; then
echo "::error title=Error uploading Sentry debug files::sentry-cli upload-dif failed after $MAX_ATTEMPTS attempts"
exit 1
fi
echo "::warning title=Sentry debug file upload failed::Attempt $attempt/$MAX_ATTEMPTS failed; retrying in ${retry_delay_seconds}s"
sleep "$retry_delay_seconds"
attempt=$((attempt + 1))
retry_delay_seconds=$((retry_delay_seconds * 2))
if [ "$retry_delay_seconds" -gt "$MAX_RETRY_DELAY_SECONDS" ]; then
retry_delay_seconds=$MAX_RETRY_DELAY_SECONDS
fi
done
Loading