Fail Sentry DIF uploads loudly after bounded retries - #15819
Open
warp-agent-staging[bot] wants to merge 1 commit into
Open
Fail Sentry DIF uploads loudly after bounded retries#15819warp-agent-staging[bot] wants to merge 1 commit into
warp-agent-staging[bot] wants to merge 1 commit into
Conversation
acarl005
approved these changes
Sep 4, 2026
|
MCP server Grafana is not active. Reconnect at http://localhost:3004/mcps/01a01a21-3ec9-71a1-99f2-f13b1773c920 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make every shared Sentry DIF upload fail the release step when
sentry-cliis unavailable, the input path is missing, or three upload attempts fail. Failed uploads retain the CLI's stdout and stderr, retry after bounded 5-second and 10-second delays, and report the successful attempt clearly.The Windows upload remains in
release_windows. That job already consumes PE and PDB artifacts from the separatebuild_windows_binariesjob, so retrying a failed bundle job does not rebuild the binaries. Reviewer focus: the shared script's failure semantics and retry bounds.Linked Issue
DEVX-8538
Testing
cmp script/sentry_upload_dif.sh /workspace/warp-internal/script/sentry_upload_dif.shbash -n script/sentry_upload_dif.sh./script/format --checkgit diff --checkcargo clippy --workspace --exclude warp_completer --all-targets --tests -- -D warningscargo clippy -p warp --all-targets --tests -- -D warningscargo clippy -p warp_completer --all-targets --tests -- -D warningsNo automated regression test is included by requester direction.
Agent Mode
CHANGELOG-NONE