Skip to content

Fail Sentry DIF uploads loudly after bounded retries - #15819

Open
warp-agent-staging[bot] wants to merge 1 commit into
masterfrom
factory/devx-8538-sentry-upload-dif
Open

Fail Sentry DIF uploads loudly after bounded retries#15819
warp-agent-staging[bot] wants to merge 1 commit into
masterfrom
factory/devx-8538-sentry-upload-dif

Conversation

@warp-agent-staging

Copy link
Copy Markdown
Contributor

Description

Make every shared Sentry DIF upload fail the release step when sentry-cli is unavailable, the input path is missing, or three upload attempts fail. Failed uploads retain the CLI's stdout and stderr, retry after bounded 5-second and 10-second delays, and report the successful attempt clearly.

The Windows upload remains in release_windows. That job already consumes PE and PDB artifacts from the separate build_windows_binaries job, so retrying a failed bundle job does not rebuild the binaries. Reviewer focus: the shared script's failure semantics and retry bounds.

Linked Issue

DEVX-8538

  • No GitHub issue; this change is tracked in Linear.
  • Screenshots are not applicable to this CI-only change.

Testing

  • cmp script/sentry_upload_dif.sh /workspace/warp-internal/script/sentry_upload_dif.sh
  • bash -n script/sentry_upload_dif.sh
  • ./script/format --check
  • git diff --check
  • cargo clippy --workspace --exclude warp_completer --all-targets --tests -- -D warnings
  • cargo clippy -p warp --all-targets --tests -- -D warnings
  • cargo clippy -p warp_completer --all-targets --tests -- -D warnings

No automated regression test is included by requester direction.

  • Local GUI testing is not applicable to this shell/CI change.

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-NONE

@cla-bot cla-bot Bot added the cla-signed label Sep 4, 2026
@warp-agent-staging
warp-agent-staging Bot marked this pull request as ready for review September 4, 2026 20:07
@warp-local-for-testing-only

Copy link
Copy Markdown

MCP server Grafana is not active. Reconnect at http://localhost:3004/mcps/01a01a21-3ec9-71a1-99f2-f13b1773c920

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant