Identify agent sessions directly in desktop health alerts - #66
Merged
Merged
Conversation
![adaptcom[bot]](https://avatars.githubusercontent.com/in/1609964?s=60&v=4){kind=small}
There was a problem hiding this comment.
Confidence Score: 4/5
Summary
Adds session identity to desktop alerts with limited presentation risk. One boundary case drops a valid title; macOS banner visibility remains unverified.
Important Files Changed
| File | Overview |
|---|---|
| .kin/supervisor-popup-notes.md | Documents identity fallbacks, metadata safeguards, and transport limitations. |
| src/kindex/supervisor_display.py | Adds bounded title lookup and compact banner formatting. |
| src/kindex/supervisor_notifications.py | Uses session-aware text while preserving transport handling. |
| tests/test_desktop_session_identity.py | Covers title selection, fallbacks, sanitization, and fixed-script transport. |
| if start: | ||
| # Only a tail title can be current: an old head title may have been | ||
| # superseded in the unread middle. Drop the partial boundary line. | ||
| data = data.split(b"\n", 1)[1] if b"\n" in data else b"" |
There was a problem hiding this comment.
Complete titles aligned with the 32 KiB read boundary are discarded; drop the first line only when the preceding byte is not a newline.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desktop health alerts currently show an alert UUID and an inbox command, so the popup does not identify the agent session when it cannot be clicked.
Show the agent, Claude session name when safely available, short session ID, readable issue, and compact project path directly in the banner. Fall back to project and ID when metadata is unavailable. Keep monitoring, acknowledgement, and retry behavior unchanged. Include project notes under
.kin/.Validation:
Implementation and tests were authored in separate agent contexts, with execution and an additional review performed separately. This is role separation, not model diversity or filesystem isolation.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.