Repository navigation
chore: read the vault ca from a configmap in integration tests - #56
Conversation
CI no longer needs access to Kubernetes Secrets: the Vault and NATS CAs are published as the vault/vault-ca and nats/nats-ca ConfigMaps. vault-tls also holds the OpenBao server private key.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused workflow change correctly removes CI’s dependency on Secret access.
Review effort: Balanced
Findings: None
What changed in this PR
Updates integration-test CI to read the OpenBao CA without requiring Secret access.
Changes:
- Reads
ca.crtfrom thevault/vault-caConfigMap. - Removes unnecessary Base64 decoding.
| File | Description |
|---|---|
.github/workflows/integration-tests.yaml |
Sources the Vault CA from a ConfigMap. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Summary
The integration-tests workflow reads the OpenBao CA from the
vault/vault-caConfigMap instead of thevault-tlsSecret.Why
Security review follow-up:
vault-tlsalso holds the OpenBao server private key, and CI's service account should have no access to Secrets. The ConfigMap is already published in dev by wanaware-infrastructure, so this can merge now.QA Report
Integration Tests
Dependencies
container.secrets.*from tf-deploy@ (CustomRole359). Same for RDE and kde's NATS CA PRs.