Skip to content

chore: read the vault ca from a configmap in integration tests - #56

Merged
muhammad-tahir-nawaz merged 1 commit into
prodfrom
chore/vault-ca-configmap
Oct 6, 2026
Merged

muhammad-tahir-nawaz merged 1 commit into
prodfrom
chore/vault-ca-configmap

Conversation

@muhammad-tahir-nawaz

Copy link
Copy Markdown
Contributor

Summary

The integration-tests workflow reads the OpenBao CA from the vault/vault-ca ConfigMap instead of the vault-tls Secret.

Why

Security review follow-up: vault-tls also holds the OpenBao server private key, and CI's service account should have no access to Secrets. The ConfigMap is already published in dev by wanaware-infrastructure, so this can merge now.

QA Report

  • No QA report required — CI workflow change, no user-facing API.

Integration Tests

  • No integration tests required — CI workflow only; exercised by the next run of the workflow.

Dependencies

  • Must merge before the wanaware-iam change that removes container.secrets.* from tf-deploy@ (CustomRole359). Same for RDE and kde's NATS CA PRs.

CI no longer needs access to Kubernetes Secrets: the Vault and NATS CAs are
published as the vault/vault-ca and nats/nats-ca ConfigMaps. vault-tls also
holds the OpenBao server private key.
Copilot AI balanced review requested due to automatic review settings October 6, 2026 13:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused workflow change correctly removes CI’s dependency on Secret access.

Review effort: Balanced
Findings: None

What changed in this PR

Updates integration-test CI to read the OpenBao CA without requiring Secret access.

Changes:

  • Reads ca.crt from the vault/vault-ca ConfigMap.
  • Removes unnecessary Base64 decoding.
File Description
.github/​workflows/​integration-tests.yaml Sources the Vault CA from a ConfigMap.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@greptile-apps

greptile-apps Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Low risk] Integration test workflow reads vault certificate from different source.

The PR appears safe to merge based on the reviewed workflow change.

Summary

The integration-tests workflow now reads the OpenBao CA from the vault/vault-ca ConfigMap rather than the vault-tls Secret, avoiding a CI read of a Secret that also contains the server private key.

Reviews (1) · Last reviewed commit: "chore: read the CA from a ConfigMap inst..."

@muhammad-tahir-nawaz
muhammad-tahir-nawaz merged commit 7c76fe9 into prod Oct 6, 2026
4 of 5 checks passed
@muhammad-tahir-nawaz
muhammad-tahir-nawaz deleted the chore/vault-ca-configmap branch October 6, 2026 13:48

This branch was successfully deployed

No deployments
development — 7fd16bb2 Deployed Oct 6, 2026 by muhammad-tahir-nawaz via Run Trivy Scan and Go Tests #78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants