Repository navigation
fix: read the nats ca from a configmap in integration tests - #58
Merged
Merged
Conversation
muhammad-tahir-nawaz
had a problem deploying
to
development
October 14, 2026 12:06 — with
GitHub Actions
Error
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused workflow change follows the established Vault CA pattern and correctly addresses the unavailable pod mount path.
0 open findings
What changed in this PR
Updates integration tests to load the NATS TLS CA from the cluster ConfigMap for port-forwarded NATS connections.
Changes:
- Fetches
nats-caand writes it to/tmp/nats-ca.crt. - Exports the runner-accessible path through
NATS_TLS_CA_FILE. - Rejects an empty CA bundle.
| File | Description |
|---|---|
.github/workflows/integration-tests.yaml |
Configures the NATS CA for integration-test runners. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
sidrarasool
approved these changes
Oct 14, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With
use_nats_port_forward, the integration-tests workflow now writes the NATS CA from thenats/nats-caConfigMap to/tmp/nats-ca.crtand pointsNATS_TLS_CA_FILEat it.Why
The service env's
NATS_TLS_CA_FILEis the pod's mount path (/etc/nats/certs/ca.crt), which does not exist on a runner, so the service under test fails its NATS TLS handshake before it starts (asset-pipeline#75:error loading or parsing rootCA file). Same pattern as the Vault CA (#56) and as RDE/kde's smoke workflows: the CA is public, CI has no access to Secrets, andcontainer.configMaps.getis already in the CI role.QA Report
Integration Tests
Dependencies
nats/nats-cais already published in dev.