Skip to content

fix: read the nats ca from a configmap in integration tests - #58

Merged
muhammad-tahir-nawaz merged 1 commit into
prodfrom
fix/nats-ca-configmap
Oct 14, 2026
Merged

muhammad-tahir-nawaz merged 1 commit into
prodfrom
fix/nats-ca-configmap

Conversation

@muhammad-tahir-nawaz

@muhammad-tahir-nawaz muhammad-tahir-nawaz commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary

With use_nats_port_forward, the integration-tests workflow now writes the NATS CA from the nats/nats-ca ConfigMap to /tmp/nats-ca.crt and points NATS_TLS_CA_FILE at it.

Why

The service env's NATS_TLS_CA_FILE is the pod's mount path (/etc/nats/certs/ca.crt), which does not exist on a runner, so the service under test fails its NATS TLS handshake before it starts (asset-pipeline#75: error loading or parsing rootCA file). Same pattern as the Vault CA (#56) and as RDE/kde's smoke workflows: the CA is public, CI has no access to Secrets, and container.configMaps.get is already in the CI role.

QA Report

  • No QA report required — CI workflow change, no user-facing API.

Integration Tests

  • No integration tests required — CI workflow only; exercised by re-running asset-pipeline#75's asset-normalizer integration test.

Dependencies

  • None. nats/nats-ca is already published in dev.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused workflow change follows the established Vault CA pattern and correctly addresses the unavailable pod mount path.

0 open findings

What changed in this PR

Updates integration tests to load the NATS TLS CA from the cluster ConfigMap for port-forwarded NATS connections.

Changes:

  • Fetches nats-ca and writes it to /tmp/nats-ca.crt.
  • Exports the runner-accessible path through NATS_TLS_CA_FILE.
  • Rejects an empty CA bundle.
File Description
.github/​workflows/​integration-tests.yaml Configures the NATS CA for integration-test runners.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@greptile-apps

greptile-apps Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Low impact] The PR appears safe to merge.

Summary

When use_nats_port_forward is enabled, the workflow reads the NATS CA from the nats/nats-ca ConfigMap.

  • NATS port-forward tests load their CA from the runner.

Reviews (1) · Last reviewed commit: "fix: read the nats ca from a configmap i..." · Reviewed by Greptile

@muhammad-tahir-nawaz
muhammad-tahir-nawaz merged commit 0d43aac into prod Oct 14, 2026
4 of 5 checks passed
@muhammad-tahir-nawaz
muhammad-tahir-nawaz deleted the fix/nats-ca-configmap branch October 14, 2026 12:10

This branch was successfully deployed

No deployments
development — 00ba3516 Deployed Oct 14, 2026 by muhammad-tahir-nawaz via Run Trivy Scan and Go Tests #80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants