ci: add Windows to test matrix

.github/workflows/ci.yml

@@ -5,6 +5,7 @@ on:
     branches: [main]
   pull_request:
     branches: [main]
+    types: [opened, synchronize, reopened, labeled]
   workflow_call:
 
 jobs:
@@ -23,10 +24,13 @@ jobs:
       - run: pnpm check
 
   test:
-    runs-on: blacksmith-4vcpu-ubuntu-2404
+    runs-on: ${{ matrix.os }}
     strategy:
       fail-fast: false
       matrix:
+        # Windows runs on main pushes and PRs labeled "test: windows"
+        os: '${{ (github.event_name == ''push'' || contains(github.event.pull_request.labels.*.name, ''test: windows'')) && fromJSON(''["blacksmith-4vcpu-ubuntu-2404","windows-latest"]'') || fromJSON(''["blacksmith-4vcpu-ubuntu-2404"]'') }}'
+        suite: [unit, core-markdown, metaframeworks, pages-react-vue, pages-svelte-solid]
         include:
           - suite: unit
             script: test:unit
@@ -52,6 +56,19 @@ jobs:
       - run: pnpm build
 
       - run: pnpm exec playwright install --with-deps chromium
-        if: matrix.suite == 'core-markdown' || matrix.suite == 'metaframeworks' || startsWith(matrix.suite, 'pages-')
+        if: matrix.suite != 'unit' && !contains(matrix.os, 'windows')
+
+      - run: pnpm exec playwright install chromium
+        if: matrix.suite != 'unit' && contains(matrix.os, 'windows')
 
       - run: pnpm ${{ matrix.script }}${{ matrix.retry && format(' --retry {0}', matrix.retry) || '' }}
+
+  done:
+    runs-on: ubuntu-latest
+    if: always()
+    needs:
+      - lint-and-check
+      - test
+    steps:
+      - run: exit 1
+        if: ${{ contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled') }}

package.json

@@ -21,7 +21,9 @@
     "test": "vitest --run"
   },
   "devDependencies": {
+    "@types/cross-spawn": "^6.0.6",
     "@typescript/native-preview": "catalog:",
+    "cross-spawn": "^7.0.6",
     "husky": "^9.1.7",
     "lint-staged": "^16.4.0",
     "oxfmt": "^0.42.0",

packages/md/test/integration/markdown-blog.test.ts

@@ -1,5 +1,6 @@
 import { describe, expect, it, beforeAll, afterAll } from "vitest";
-import { execSync, spawn } from "node:child_process";
+import { execSync } from "node:child_process";
+import spawn from "cross-spawn";
 import { join } from "node:path";
 import { chromium, type Browser, type Page } from "playwright";
 import { getPort, waitForServer, killChild } from "../../../../test/integration-helpers";

packages/react/test/integration/react-pages-client.test.ts

@@ -1,5 +1,6 @@
 import { describe, expect, it, beforeAll, afterAll } from "vitest";
-import { execSync, spawn } from "node:child_process";
+import { execSync } from "node:child_process";
+import spawn from "cross-spawn";
 import { join } from "node:path";
 import { readFileSync, writeFileSync } from "node:fs";
 import { chromium, type Browser, type Page } from "playwright";
@@ -784,7 +785,7 @@
   });
 }, 60_000);
 
 describe("react-pages client (preview)", { retry: 2, timeout: 60_000 }, () => {
   let child: ReturnType<typeof spawn>;
   let stderr = "";
 

packages/solid/test/integration/solid-pages-playground.test.ts

@@ -1,5 +1,6 @@
 import { afterAll, beforeAll, describe, expect, it } from "vitest";
-import { execSync, spawn } from "node:child_process";
+import { execSync } from "node:child_process";
+import spawn from "cross-spawn";
 import { join } from "node:path";
 import { readFileSync, writeFileSync } from "node:fs";
 import { chromium, type Browser, type Page } from "playwright";
@@ -719,7 +720,7 @@
   });
 }, 60_000);
 
 describe("solid-pages client (preview)", { retry: 2, timeout: 60_000 }, () => {
   let child: ReturnType<typeof spawn>;
   let stderr = "";
 

packages/svelte/test/integration/svelte-pages-client.test.ts

@@ -1,5 +1,6 @@
 import { describe, expect, it, beforeAll, afterAll } from "vitest";
-import { execSync, spawn } from "node:child_process";
+import { execSync } from "node:child_process";
+import spawn from "cross-spawn";
 import { join } from "node:path";
 import { readFileSync, writeFileSync } from "node:fs";
 import { chromium, type Browser, type Page } from "playwright";
@@ -722,7 +723,7 @@
   });
 }, 60_000);
 
 describe("svelte-pages client (preview)", { retry: 2, timeout: 60_000 }, () => {
   let child: ReturnType<typeof spawn>;
   let stderr = "";
 

packages/void/test/integration/astro.test.ts

@@ -1,5 +1,6 @@
 import { afterAll, beforeAll, describe, expect, it } from "vitest";
-import { execSync, spawn } from "node:child_process";
+import { execSync } from "node:child_process";
+import spawn from "cross-spawn";
 import { existsSync, readFileSync, rmSync } from "node:fs";
 import { join } from "node:path";
 import { getPort, waitForServer, killChild } from "../../../../test/integration-helpers";

packages/void/test/integration/kitchen-sink-build.test.ts

@@ -1,7 +1,8 @@
 import { beforeAll, describe, expect, it } from "vitest";
-import { spawnSync } from "node:child_process";
+import spawn from "cross-spawn";
 import { existsSync, readFileSync, readdirSync, rmSync } from "node:fs";
 import { join } from "node:path";
+import { toSlash } from "../../src/shared/utils";
 
 const ROOT = join(import.meta.dirname, "..", "..", "..", "..");
 const PLAYGROUND = "playground/kitchen-sink";
@@ -15,14 +16,14 @@
     rmSync(join(pg, "dist"), { recursive: true, force: true });
     rmSync(join(pg, ".void"), { recursive: true, force: true });
 
-    const result = spawnSync("pnpm", ["--dir", PLAYGROUND, "build"], {
+    const result = spawn.sync("pnpm", ["--dir", PLAYGROUND, "build"], {
       cwd: ROOT,
       encoding: "utf8",
       maxBuffer: 10 * 1024 * 1024,
     });
 
     buildOutput = `${result.stdout ?? ""}${result.stderr ?? ""}`;
     expect(result.status).toBe(0);
   }, 120_000);
 
   it("emits the SSR worker entry", () => {
@@ -51,7 +52,7 @@
 function collectFiles(dir: string): string[] {
   const files: string[] = [];
   for (const entry of readdirSync(dir, { withFileTypes: true })) {
-    const entryPath = join(dir, entry.name);
+    const entryPath = toSlash(join(dir, entry.name));
     if (entry.isDirectory()) {
       files.push(...collectFiles(entryPath));
     } else {

packages/void/test/integration/kitchen-sink.test.ts

@@ -1,5 +1,6 @@
 import { describe, expect, it, beforeAll, afterAll } from "vitest";
-import { execSync, spawn } from "node:child_process";
+import { execSync } from "node:child_process";
+import spawn from "cross-spawn";
 import { join } from "node:path";
 import { rmSync } from "node:fs";
 import { chromium, type Browser, type Page } from "playwright";

packages/void/test/integration/named-layouts.test.ts

@@ -1,5 +1,5 @@
 import { describe, expect, it, beforeAll, afterAll } from "vitest";
-import { spawn } from "node:child_process";
+import spawn from "cross-spawn";
 import { join } from "node:path";
 import { getPort, waitForServer, killChild } from "../../../../test/integration-helpers";
 

packages/void/test/integration/node-target.test.ts

@@ -1,10 +1,11 @@
 import { afterAll, beforeAll, describe, expect, it } from "vitest";
-import { execSync, spawn } from "node:child_process";
+import { execSync } from "node:child_process";
+import spawn from "cross-spawn";
 import { existsSync, readFileSync, rmSync } from "node:fs";
 import { join } from "node:path";
 import { getPort, waitForServer, killChild } from "../../../../test/integration-helpers";
 
-const ROOT = new URL("../../../..", import.meta.url).pathname;
+const ROOT = join(import.meta.dirname, "..", "..", "..", "..");
 let DEV_PORT: number;
 let DEV_BASE: string;
 let PROD_PORT: number;

packages/void/test/integration/nuxt.test.ts

@@ -1,5 +1,6 @@
 import { afterAll, beforeAll, describe, expect, it } from "vitest";
-import { execSync, spawn } from "node:child_process";
+import { execSync } from "node:child_process";
+import spawn from "cross-spawn";
 import { existsSync, readFileSync, rmSync } from "node:fs";
 import { join } from "node:path";
 import { getPort, waitForServer, killChild } from "../../../../test/integration-helpers";

packages/void/test/integration/pg-test.test.ts

@@ -1,6 +1,6 @@
 import { afterAll, beforeAll, describe, expect, it } from "vitest";
 import { readFileSync, writeFileSync, unlinkSync } from "node:fs";
-import { spawn } from "node:child_process";
+import spawn from "cross-spawn";
 import { join } from "node:path";
 import { once } from "node:events";
 import { PGlite } from "@electric-sql/pglite";

packages/void/test/integration/react-router.test.ts

@@ -1,5 +1,6 @@
 import { afterAll, beforeAll, describe, expect, it } from "vitest";
-import { execSync, spawn } from "node:child_process";
+import { execSync } from "node:child_process";
+import spawn from "cross-spawn";
 import { existsSync, readFileSync, rmSync } from "node:fs";
 import { join } from "node:path";
 import { getPort, waitForServer, killChild } from "../../../../test/integration-helpers";
@@ -42,7 +43,7 @@
   });
 });
 
 describe("playground/react-router dev", { retry: 2, timeout: 60_000 }, () => {
   let child: ReturnType<typeof spawn>;
   let stderr = "";
 

packages/void/test/integration/ssr-playground.test.ts

@@ -1,5 +1,6 @@
 import { afterAll, beforeAll, describe, expect, it } from "vitest";
-import { execSync, spawn } from "node:child_process";
+import { execSync } from "node:child_process";
+import spawn from "cross-spawn";
 import { existsSync, readFileSync, rmSync } from "node:fs";
 import { join } from "node:path";
 import { getPort, waitForServer, killChild } from "../../../../test/integration-helpers";

packages/void/test/integration/sveltekit.test.ts

@@ -1,5 +1,6 @@
 import { afterAll, beforeAll, describe, expect, it } from "vitest";
-import { execSync, spawn } from "node:child_process";
+import { execSync } from "node:child_process";
+import spawn from "cross-spawn";
 import { existsSync, readFileSync, rmSync, writeFileSync } from "node:fs";
 import { join } from "node:path";
 import { getPort, waitForServer, killChild } from "../../../../test/integration-helpers";

packages/void/test/integration/tanstack-start.test.ts

@@ -1,5 +1,6 @@
 import { afterAll, beforeAll, describe, expect, it } from "vitest";
-import { execSync, spawn } from "node:child_process";
+import { execSync } from "node:child_process";
+import spawn from "cross-spawn";
 import { existsSync, readFileSync, rmSync } from "node:fs";
 import { join } from "node:path";
 import { getPort, waitForServer, killChild } from "../../../../test/integration-helpers";

packages/void/test/integration/vinext-app.test.ts

@@ -1,5 +1,6 @@
 import { afterAll, beforeAll, describe, expect, it } from "vitest";
-import { execSync, spawn } from "node:child_process";
+import { execSync } from "node:child_process";
+import spawn from "cross-spawn";
 import { existsSync, readFileSync, rmSync } from "node:fs";
 import { join } from "node:path";
 import { getPort, waitForServer, killChild } from "../../../../test/integration-helpers";

packages/void/test/integration/vinext-pages.test.ts

@@ -1,5 +1,6 @@
 import { afterAll, beforeAll, describe, expect, it } from "vitest";
-import { execSync, spawn } from "node:child_process";
+import { execSync } from "node:child_process";
+import spawn from "cross-spawn";
 import { existsSync, readFileSync, rmSync } from "node:fs";
 import { join } from "node:path";
 import { getPort, waitForServer, killChild } from "../../../../test/integration-helpers";

packages/void/test/integration/websockets-playground.test.ts

@@ -1,5 +1,5 @@
 import { afterAll, beforeAll, describe, expect, it } from "vitest";
-import { spawn } from "node:child_process";
+import spawn from "cross-spawn";
 import { join } from "node:path";
 import { chromium, type Browser, type Page } from "playwright";
 import { getPort, killChild, waitForServer } from "../../../../test/integration-helpers";

packages/vue/test/integration/vue-pages-client.test.ts

@@ -1,5 +1,6 @@
 import { describe, expect, it, beforeAll, afterAll } from "vitest";
-import { execSync, spawn } from "node:child_process";
+import { execSync } from "node:child_process";
+import spawn from "cross-spawn";
 import { join } from "node:path";
 import { readFileSync, writeFileSync } from "node:fs";
 import { chromium, type Browser, type Page } from "playwright";
@@ -734,7 +735,7 @@
         if (hmrDelivered) {
           // Verify it was a hot update, not a full page reload
           const markerSurvived = await page.evaluate(() => (window as any).__hmr_marker === true);
           expect(markerSurvived).toBe(true);
         }
       } finally {
         await page.context().close();
@@ -764,6 +765,9 @@
         () => document.querySelector('[data-testid="count"]')?.textContent === "Count: 1",
       );
 
+      // Wait a bit for reactive state to stabilize before HMR (Windows can be slower)
+      await new Promise((r) => setTimeout(r, 200));
+
       // Set a window marker to detect full page reload
       await page.evaluate(() => {
         (window as any).__hmr_marker = true;
@@ -831,7 +835,7 @@
   });
 }, 60_000);
 
 describe("vue-pages client (preview)", { retry: 2, timeout: 60_000 }, () => {
   let child: ReturnType<typeof spawn>;
   let stderr = "";
 

test/integration-helpers.ts

@@ -1,6 +1,6 @@
 import { createServer, type Server } from "node:net";
 import { once } from "node:events";
-import type { spawn } from "node:child_process";
+import { execSync, type spawn } from "node:child_process";
 
 /**
  * Ports held by getPort() until waitForServer() releases them.
@@ -63,7 +63,18 @@ export async function waitForServer(
 
 export async function killChild(child: ReturnType<typeof spawn>): Promise<void> {
   if (child.exitCode === null && child.signalCode === null) {
-    child.kill("SIGTERM");
+    if (process.platform === "win32" && child.pid) {
+      // On Windows, SIGTERM doesn't propagate to child processes.
+      // Use taskkill /T to kill the entire process tree (e.g. workerd.exe).
+      // See: https://github.com/voidzero-dev/void/actions/runs/23939152784/job/69826006981?pr=63
+      try {
+        execSync(`taskkill /pid ${child.pid} /T /F`, { stdio: "ignore" });
+      } catch {
+        // Process may have already exited
+      }
+    } else {
+      child.kill("SIGTERM");
+    }
     await Promise.race([once(child, "exit"), new Promise((resolve) => setTimeout(resolve, 5_000))]);
     if (child.exitCode === null && child.signalCode === null) {
       child.kill("SIGKILL");