Skip to content

ci: add Windows to test matrix - #63

Merged
Brooooooklyn merged 10 commits into
mainfrom
04-01-ci_add_windows_to_test_matrix
Apr 6, 2026
Merged

ci: add Windows to test matrix#63
Brooooooklyn merged 10 commits into
mainfrom
04-01-ci_add_windows_to_test_matrix

Conversation

@shulaoda

@shulaoda shulaoda commented Apr 1, 2026 •
edited by Claude AI
Loading

Copy link
Copy Markdown
Member

No description provided.

@shulaoda
shulaoda force-pushed the 04-01-ci_add_windows_to_test_matrix branch from 12fbbe6 to 95fc7f0 Compare April 1, 2026 10:45
@cpojer

cpojer commented Apr 2, 2026

Copy link
Copy Markdown
Member

Please let's only run tests on Windows on main for now, I don't want us to be slowed down right now.

@shulaoda shulaoda mentioned this pull request Apr 2, 2026
Merged
@shulaoda
shulaoda force-pushed the 04-01-ci_add_windows_to_test_matrix branch 4 times, most recently from 94f8270 to ff73923 Compare April 3, 2026 07:46
@shulaoda
shulaoda force-pushed the 04-01-ci_add_windows_to_test_matrix branch from ff73923 to ede45d4 Compare April 3, 2026 08:03
@shulaoda
shulaoda marked this pull request as ready for review April 3, 2026 10:50
@shulaoda
shulaoda marked this pull request as draft April 3, 2026 10:51
@shulaoda
shulaoda marked this pull request as ready for review April 3, 2026 10:52
@shulaoda
shulaoda marked this pull request as draft April 3, 2026 10:52
@shulaoda
shulaoda marked this pull request as ready for review April 3, 2026 11:01
@Brooooooklyn

Brooooooklyn commented Apr 6, 2026

Copy link
Copy Markdown
Member

@claude[agent] add a done job which is required all other jobs https://github.com/voidzero-dev/vite-plus/blob/main/.github/workflows/ci.yml#L829-L842
So our branch protection rule can only rely on the done job and simplify our configuration

@Claude @Brooooooklyn
ci: add done job for simplified branch protection
0577a83 
Agent-Logs-Url: https://github.com/voidzero-dev/void/sessions/2c4f242a-32f1-4498-ada5-6dba1d9d9803

Co-authored-by: Brooooooklyn <3468483+Brooooooklyn@users.noreply.github.com>
@Claude

Claude AI commented Apr 6, 2026 •
edited
Loading

Copy link
Copy Markdown

Please let's only run tests on Windows on main for now, I don't want us to be slowed down right now.

Done in 90db415 - Windows tests now only run on main pushes and PRs with the "test: windows" label.

@claude[agent] add a done job which is required all other jobs https://github.com/voidzero-dev/vite-plus/blob/main/.github/workflows/ci.yml#L829-L842
So our branch protection rule can only rely on ...

Added in 0577a83 - the done job now depends on lint-and-check and test, and exits with code 1 if any dependent job failed or was cancelled. Branch protection can now be configured to only require the done job.

@Brooooooklyn

Brooooooklyn commented Apr 6, 2026

Copy link
Copy Markdown
Member

@claude[agent] our [CI / test (windows-latest, pages-react-vue) (pull_request)](https://github.com/voidzero-dev/void/actions/runs/24025471732/job/70062891006?pr=63)Failing after 2m is flaky, fix the e2e test on Windows

@Claude @Brooooooklyn
fix(test): add stabilization delay before HMR in Vue Pages test for W…
9d9ecf4 
…indows

Agent-Logs-Url: https://github.com/voidzero-dev/void/sessions/04814680-5700-497a-b8b6-1620646356e2

Co-authored-by: Brooooooklyn <3468483+Brooooooklyn@users.noreply.github.com>
@Claude

Claude AI commented Apr 6, 2026

Copy link
Copy Markdown

@claude[agent] our [CI / test (windows-latest, pages-react-vue) (pull_request)](https://github.com/voidzero-dev/void/actions/runs/24025471732/job/70062891006?pr=63)Failing after 2m is flaky, fix the...

Fixed in 9d9ecf4. The vue-pages-client.test.ts > island component HMR updates without full page reload test was failing because reactive state wasn't fully stabilized before the file modification triggered HMR on Windows. Added a 200ms stabilization delay after the button click to ensure the Vue reactivity system commits the state change before HMR kicks in.

@Claude Claude AI changed the title ci: add Windows to test matrix Addressing PR comments Apr 6, 2026
@Brooooooklyn Brooooooklyn changed the title Addressing PR comments ci: add Windows to test matrix Apr 6, 2026
@Brooooooklyn
Brooooooklyn merged commit edc14e5 into main Apr 6, 2026
12 checks passed
@Brooooooklyn
Brooooooklyn deleted the 04-01-ci_add_windows_to_test_matrix branch April 6, 2026 14:29
cpojer pushed a commit that referenced this pull request Sep 11, 2026
@Brooooooklyn @claude
fix(api): use session JWT for all bucket uploads, not chained JWTs (#63)
8d45aa8 
CF only returns a completion JWT in the final bucket response. Non-final
buckets return 202 with no JWT. Our code treated missing JWTs as errors
and retried, causing multi-bucket deploys to always fail with
"asset upload failed for bucket 1/3 after retries".

Fix by using the session JWT for auth on all uploads (matching Wrangler)
and only expecting a completion JWT from the last bucket.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpojer cpojer cpojer approved these changes
@Brooooooklyn Brooooooklyn Brooooooklyn approved these changes
@yyx990803 yyx990803 Awaiting requested review from yyx990803

Assignees

No one assigned

Labels

test: windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shulaoda @cpojer @Brooooooklyn @Claude