Repository navigation
Fix Cloudflare platform installation, native readiness, auth forms, and shared email - #357
Merged
Merged
Conversation
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
|
Brooooooklyn
force-pushed
the
codex/platform-cloudflare-e2e-fixes
branch
from
October 1, 2026 18:09
9e6a01a to
80dec5a
Compare
Member
|
Can you write maybe slightly fewer tests. |
Brooooooklyn
added a commit
that referenced
this pull request
Oct 2, 2026
The private secret bootstrap leaves a Worker created through the API. The first application deploy misclassifies its current SDK placeholder and probes a disabled preview. After the first publication, an ordinary revision can also stop before upload because the pinned cf CLI asks for confirmation when the active Worker was last updated through the API. Recognize the exact SDK placeholder from immutable module bytes, secret-only bindings, source annotation and disabled URLs. Pin the inspected active secrets before initial publication and ordinary inherited-secret revisions, and recheck that the same version owns all production traffic before upload. Use the existing version-aware uploader for those revisions while retaining staged preview/readiness checks. Explicit secret replacements and apps without remote secrets retain their existing upload behavior. Placeholder recognition relies on the callers' existing version matching and ignores unused version-number, date and usage-model metadata. It adds no UUID/date regex validation. Bound optional module inspection, recheck ownership around publication and callbacks, and report the actual published UUID if a callback fails after publication. Also preserve manually configured email bindings when automatic setup is skipped, retain the strict `--require-email` gate, and document preparing the standalone self-hosted dashboard and checking genuine email delivery/authentication. Maintainer guidance describes the two upload paths. Validation: - Rebased onto main at `d4a27907` without conflicts. All four existing patches are identical after rebase; the removed redundant validation stays removed. - Stabilized one existing invitation-delivery test by holding its clock within one UTC-minute rate-limit window and restoring it afterward. Advancing the clock across a minute reproduced the exact CI failure; the focused test, all 28 tests in its file, and affected-file verification pass. Production behavior is unchanged. - Final head `08e55889` passed `CI=true vp test run`: 669 files, 12,624 tests, 25 skipped, 273.02 seconds. All 28 `vp run check` package typechecks passed. Formatting, ordinary/type-aware platform lint, all SDK/platform/playground builds and build-artifact checks passed on the rebased implementation; the subsequent test-only change passed formatting/lint and commit hooks. Worktree and diff checks are clean. - The earlier full run passed all test assertions but exited on a Node/Undici `setTypeOfService EINVAL` socket error. The isolated SSR test and final full suite passed without changing production code or suppressing errors. - Exact final head `08e55889` passed all four Actions workflows (CI, Platform CI, Prepublish and Security), including the repaired integration job, schema compatibility and required `done`. No checks remain pending. The independent external Cloudflare build failed; its diagnostic remains unavailable. - Previously captured live evidence: a genuine private SDK bootstrap and subsequent ordinary native revision completed readiness, active/served version matching and anonymous authorization refusal. Genuine SEND arrived in Gmail with Cloudflare Received headers and passing SPF/DKIM; RECEIVE and SMTP REJECT were observed. REPLY/FORWARD action recording is proven but mailbox delivery remains unconfirmed. The original REPLY input later received a route-unavailable DSN after cleanup; its initial provider outcome is unknown. DMARC policy readiness is incomplete. Exact owned email, runtime and Workflow cleanup preserved unrelated resources. This follows the installation and runtime fixes already merged in #357. Managed signup/admin/user/team/Zero Trust acceptance remains blocked at administrator confirmation, while Sandbox execution and fresh HTTP log acceptance remain incomplete. These native results do not establish full managed-platform acceptance. No new dependencies or Workers Paid requirement for ordinary apps are introduced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-hosted Cloudflare installation and native custom-domain deployment exposed failures in authentication forms, recovery, candidate readiness, and shared inbound email. This change fixes those paths and adds guarded acceptance fixtures and regressions.
Validation at head ee32f5b:
Managed live acceptance remains incomplete: the built-in browser blocks the approved /auth/bootstrap/confirm submission with net::ERR_BLOCKED_BY_CLIENT before a server response. Current readback has zero users and an expired unconsumed bootstrap. Genuine user signup/deployments, admin/user management, teams, real email receipt, managed Zero Trust, user queue consumption and Sandbox execution have not passed live acceptance. Prepared runners are not executed tests. The isolated live installation retains its earlier fork migration history; this canonical runtime has not been applied to that fork.
Credentials, private recovery files and workstation acceptance logs are excluded.