Skip to content

Fix native deploys after private secret bootstrap - #358

Merged
Brooooooklyn merged 5 commits into
mainfrom
codex/platform-cloudflare-e2e-fixes
Oct 2, 2026
Merged

Brooooooklyn merged 5 commits into
mainfrom
codex/platform-cloudflare-e2e-fixes

Conversation

@Brooooooklyn

@Brooooooklyn Brooooooklyn commented Oct 2, 2026 •

Copy link
Copy Markdown
Member

The private secret bootstrap leaves a Worker created through the API. The first application deploy misclassifies its current SDK placeholder and probes a disabled preview. After the first publication, an ordinary revision can also stop before upload because the pinned cf CLI asks for confirmation when the active Worker was last updated through the API.

Recognize the exact SDK placeholder from immutable module bytes, secret-only bindings, source annotation and disabled URLs. Pin the inspected active secrets before initial publication and ordinary inherited-secret revisions, and recheck that the same version owns all production traffic before upload. Use the existing version-aware uploader for those revisions while retaining staged preview/readiness checks. Explicit secret replacements and apps without remote secrets retain their existing upload behavior.

Placeholder recognition relies on the callers' existing version matching and ignores unused version-number, date and usage-model metadata. It adds no UUID/date regex validation.

Bound optional module inspection, recheck ownership around publication and callbacks, and report the actual published UUID if a callback fails after publication. Also preserve manually configured email bindings when automatic setup is skipped, retain the strict --require-email gate, and document preparing the standalone self-hosted dashboard and checking genuine email delivery/authentication. Maintainer guidance describes the two upload paths.

Validation:

  • Rebased onto main at d4a27907 without conflicts. All four existing patches are identical after rebase; the removed redundant validation stays removed.
  • Stabilized one existing invitation-delivery test by holding its clock within one UTC-minute rate-limit window and restoring it afterward. Advancing the clock across a minute reproduced the exact CI failure; the focused test, all 28 tests in its file, and affected-file verification pass. Production behavior is unchanged.
  • Final head 08e55889 passed CI=true vp test run: 669 files, 12,624 tests, 25 skipped, 273.02 seconds. All 28 vp run check package typechecks passed. Formatting, ordinary/type-aware platform lint, all SDK/platform/playground builds and build-artifact checks passed on the rebased implementation; the subsequent test-only change passed formatting/lint and commit hooks. Worktree and diff checks are clean.
  • The earlier full run passed all test assertions but exited on a Node/Undici setTypeOfService EINVAL socket error. The isolated SSR test and final full suite passed without changing production code or suppressing errors.
  • Exact final head 08e55889 passed all four Actions workflows (CI, Platform CI, Prepublish and Security), including the repaired integration job, schema compatibility and required done. No checks remain pending. The independent external Cloudflare build failed; its diagnostic remains unavailable.
  • Previously captured live evidence: a genuine private SDK bootstrap and subsequent ordinary native revision completed readiness, active/served version matching and anonymous authorization refusal. Genuine SEND arrived in Gmail with Cloudflare Received headers and passing SPF/DKIM; RECEIVE and SMTP REJECT were observed. REPLY/FORWARD action recording is proven but mailbox delivery remains unconfirmed. The original REPLY input later received a route-unavailable DSN after cleanup; its initial provider outcome is unknown. DMARC policy readiness is incomplete. Exact owned email, runtime and Workflow cleanup preserved unrelated resources.

This follows the installation and runtime fixes already merged in #357. Managed signup/admin/user/team/Zero Trust acceptance remains blocked at administrator confirmation, while Sandbox execution and fresh HTTP log acceptance remain incomplete. These native results do not establish full managed-platform acceptance. No new dependencies or Workers Paid requirement for ordinary apps are introduced.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Failed ❌

View logs ↗
08e5588 2026-10-02T16:50:38.361Z View logs ↗
  • Build: Failed ❌

View logs ↗
44db7ac 2026-10-02T16:35:35.597Z View logs ↗
  • Build: Failed ❌

View logs ↗
048ed10 2026-10-02T16:33:33.129Z View logs ↗
  • Build: Failed ❌

View logs ↗
03c3640 2026-10-02T14:22:06.175Z View logs ↗
  • Build: Failed ❌

View logs ↗
d702079 2026-10-02T14:04:29.543Z View logs ↗
  • Build: Failed ❌

View logs ↗
842882f 2026-10-02T03:36:13.277Z View logs ↗
  • Build: Failed ❌

View logs ↗
f1d56e0 2026-10-02T03:20:43.601Z View logs ↗
  • Build: Failed ❌

View logs ↗
638a12c 2026-10-02T02:51:27.012Z View logs ↗
  • Build: Failed ❌

View logs ↗
b8ae67a 2026-10-02T01:47:32.686Z View logs ↗

@Brooooooklyn
Brooooooklyn force-pushed the codex/platform-cloudflare-e2e-fixes branch from f1d56e0 to 842882f Compare October 2, 2026 03:35
@Brooooooklyn Brooooooklyn changed the title Fix first native deploys after private secret bootstrap Fix native deploys after private secret bootstrap Oct 2, 2026
@Brooooooklyn
Brooooooklyn marked this pull request as ready for review October 2, 2026 03:44
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@Brooooooklyn
Brooooooklyn force-pushed the codex/platform-cloudflare-e2e-fixes branch 2 times, most recently from 03c3640 to 048ed10 Compare October 2, 2026 16:32
@Brooooooklyn
Brooooooklyn force-pushed the codex/platform-cloudflare-e2e-fixes branch from 048ed10 to 44db7ac Compare October 2, 2026 16:34
@Brooooooklyn
Brooooooklyn merged commit 9c84fef into main Oct 2, 2026
19 of 20 checks passed
@Brooooooklyn
Brooooooklyn deleted the codex/platform-cloudflare-e2e-fixes branch October 2, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant