Repository navigation
Fix native deploys after private secret bootstrap - #358
Merged
Merged
Conversation
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
|
Brooooooklyn
force-pushed
the
codex/platform-cloudflare-e2e-fixes
branch
from
October 2, 2026 03:35
f1d56e0 to
842882f
Compare
Brooooooklyn
marked this pull request as ready for review
October 2, 2026 03:44
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Brooooooklyn
force-pushed
the
codex/platform-cloudflare-e2e-fixes
branch
2 times, most recently
from
October 2, 2026 16:32
03c3640 to
048ed10
Compare
Brooooooklyn
force-pushed
the
codex/platform-cloudflare-e2e-fixes
branch
from
October 2, 2026 16:34
048ed10 to
44db7ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The private secret bootstrap leaves a Worker created through the API. The first application deploy misclassifies its current SDK placeholder and probes a disabled preview. After the first publication, an ordinary revision can also stop before upload because the pinned cf CLI asks for confirmation when the active Worker was last updated through the API.
Recognize the exact SDK placeholder from immutable module bytes, secret-only bindings, source annotation and disabled URLs. Pin the inspected active secrets before initial publication and ordinary inherited-secret revisions, and recheck that the same version owns all production traffic before upload. Use the existing version-aware uploader for those revisions while retaining staged preview/readiness checks. Explicit secret replacements and apps without remote secrets retain their existing upload behavior.
Placeholder recognition relies on the callers' existing version matching and ignores unused version-number, date and usage-model metadata. It adds no UUID/date regex validation.
Bound optional module inspection, recheck ownership around publication and callbacks, and report the actual published UUID if a callback fails after publication. Also preserve manually configured email bindings when automatic setup is skipped, retain the strict
--require-emailgate, and document preparing the standalone self-hosted dashboard and checking genuine email delivery/authentication. Maintainer guidance describes the two upload paths.Validation:
d4a27907without conflicts. All four existing patches are identical after rebase; the removed redundant validation stays removed.08e55889passedCI=true vp test run: 669 files, 12,624 tests, 25 skipped, 273.02 seconds. All 28vp run checkpackage typechecks passed. Formatting, ordinary/type-aware platform lint, all SDK/platform/playground builds and build-artifact checks passed on the rebased implementation; the subsequent test-only change passed formatting/lint and commit hooks. Worktree and diff checks are clean.setTypeOfService EINVALsocket error. The isolated SSR test and final full suite passed without changing production code or suppressing errors.08e55889passed all four Actions workflows (CI, Platform CI, Prepublish and Security), including the repaired integration job, schema compatibility and requireddone. No checks remain pending. The independent external Cloudflare build failed; its diagnostic remains unavailable.This follows the installation and runtime fixes already merged in #357. Managed signup/admin/user/team/Zero Trust acceptance remains blocked at administrator confirmation, while Sandbox execution and fresh HTTP log acceptance remain incomplete. These native results do not establish full managed-platform acceptance. No new dependencies or Workers Paid requirement for ordinary apps are introduced.