Repository navigation
fix(void): better asset routing pipeline - #209
Merged
Merged
Conversation
✅ Deploy Preview for staging-void-cloud ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
TheAlexLichter
marked this pull request as draft
May 18, 2026 14:51
TheAlexLichter
changed the title
TheAlexLichter
force-pushed
the
fix/asset-routing-pipeline
branch
from
May 18, 2026 15:11
306f9b3 to
4f6a6ee
Compare
TheAlexLichter
marked this pull request as ready for review
May 18, 2026 16:02
cpojer
approved these changes
May 19, 2026
cpojer
pushed a commit
that referenced
this pull request
Sep 11, 2026
…cates (#209) Tests 5 (KV) and 8 (Queues) passed a predicate to page.waitForResponse whose parameter is `response`, but the body referenced an undefined `r`, so every run threw `page.waitForResponse: r is not defined` (ReferenceError). `r` is a leftover from renaming the param `r` -> `response` in #45 that missed these two `.request()` calls. Latent since #45 (Mar 22) — the smoke test never reached the test phase until the deploy step was unblocked in #208. With deploy fixed, 9/11 tests pass and only these two failed for this reason. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to create a clear asset routing pipeline and avoids confusion about when the following components of the platform trigger:
Change overview table
mainbehavior404.htmlor a platform 404./index.html; userrouting.fallbacksstill layer in front of the implicit SPA fallback./apiroutesroutes/file was treated as worker-owned HTML. This preserved API-before-fallback semantics, but also routed frontend navigations through the worker instead of using platform SPA fallback directly./apiand/api/*no longer count as document routes. API-only apps are kept closer to static SPA behavior, with the tradeoff that API-before-fallback semantics depend on asset-platform fallthrough unless API paths are separately scoped worker-first.middleware/, managed auth, non-/apiroutes, WebSockets, or live bindingsnot_found_handling: "none"andrun_worker_first; after routes and middleware run, non-SSR/non-Pages apps serve/index.htmlfor unmatched HTML requests.run_worker_firstshape. Live bindings were not part of the shared asset-routing decision.not_found_handling: "none"and did not rely on platform SPA fallback for HTML.run_worker_firstis explicit where Void owns the worker config.Follow-up of #165