Skip to content

Commit bb90aae

Browse files
Brooooooklynclaude
andauthored
fix(smoke): reference response not undefined r in KV/Queues predicates (#209)
Tests 5 (KV) and 8 (Queues) passed a predicate to page.waitForResponse whose parameter is `response`, but the body referenced an undefined `r`, so every run threw `page.waitForResponse: r is not defined` (ReferenceError). `r` is a leftover from renaming the param `r` -> `response` in #45 that missed these two `.request()` calls. Latent since #45 (Mar 22) — the smoke test never reached the test phase until the deploy step was unblocked in #208. With deploy fixed, 9/11 tests pass and only these two failed for this reason. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 14c8a85 commit bb90aae

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

‎scripts/kitchen-sink-smoke-test.ts‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@ void describe(`kitchen-sink smoke (${BASE})`, { concurrency: true }, () => {
274274
await page.fill('input[placeholder="my-value"]', 'hello');
275275
await Promise.all([
276276
page.waitForResponse(
277-
(response) => response.url().includes('/kv') && r.request().method() === 'POST',
277+
(response) => response.url().includes('/kv') && response.request().method() === 'POST',
278278
),
279279
page.click('button:has-text("Set")'),
280280
]);
@@ -364,7 +364,8 @@ void describe(`kitchen-sink smoke (${BASE})`, { concurrency: true }, () => {
364364
await page.fill('input[placeholder="my-value"]', 'queued');
365365
await Promise.all([
366366
page.waitForResponse(
367-
(response) => response.url().includes('/queues') && r.request().method() === 'POST',
367+
(response) =>
368+
response.url().includes('/queues') && response.request().method() === 'POST',
368369
),
369370
page.click('button:has-text("Send to Queue")'),
370371
]);

0 commit comments

Comments
 (0)