Repository navigation
Conversation
hyfdev
force-pushed
the
fix/collect-prerender-paths-user-plugins
branch
from
March 3, 2026 11:59
241d5f3 to
a64c031
Compare
hyfdev
changed the title
hyfdev
force-pushed
the
fix/collect-prerender-paths-user-plugins
branch
from
March 3, 2026 12:14
a64c031 to
bc8e1e2
Compare
This was referenced Mar 3, 2026
hyfdev
changed the title
hyfdev
force-pushed
the
fix/collect-prerender-paths-user-plugins
branch
3 times, most recently
from
March 3, 2026 12:23
f5b3035 to
2a79e56
Compare
This comment was marked as outdated.
This comment was marked as outdated.
…port collectPrerenderPaths() now loads the user's full vite.config via loadConfigFromFile() so that user-defined plugins (virtual modules, resolve aliases, etc.) are available when ssrLoadModule() runs getPrerenderPaths(). - Use process.env.NODE_ENV for mode detection - Throw on failed config load instead of silent fallback - Throw on prerender path resolution errors instead of console.warn - Replace categories test fixture with tags/virtual:tags fixture
hyfdev
force-pushed
the
fix/collect-prerender-paths-user-plugins
branch
from
March 4, 2026 02:49
2a79e56 to
2e9c5ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
collectPrerenderPaths()previously created a bare Vite dev server without loading the user's config. This meantssrLoadModule()rangetPrerenderPaths()in a different environment than the user's actual app — missing plugins, resolve aliases, SSR options, and any other config the user depends on. Any code that relied on user-configured Vite behavior would silently break.Now it loads the user's full
vite.configvialoadConfigFromFile(), ensuringssrLoadModule()runs in the same environment as the rest of the build.Changes
@cloudflare/vite-pluginplugins that breakssrLoadModule)process.env.NODE_ENVfor mode detection when loading configconsole.warntags/[tag]fixture withvirtual:tagspluginConsolidates #13 (virtual module tests) and #14 (console.warn → throw).