Repository navigation
Conversation
If a user exports getPrerenderPaths and it fails to resolve (e.g. missing virtual module, unresolved alias), the build should fail with a clear error instead of silently skipping the page. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
hyfdev
changed the title
There was a problem hiding this comment.
Pull request overview
This PR makes prerender path collection fail the build when a user-defined getPrerenderPaths cannot be resolved or throws, instead of silently warning and continuing (applies to both pages-mode dynamic routes and custom SSR mode).
Changes:
- Replace
console.warnwith thrown errors for failures while resolving dynamic page prerender paths. - Replace
console.warnwith thrown errors for failures while resolving custom SSR prerender paths.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hyfdev
changed the title
getPrerenderPaths instead of silent warning
Address PR review feedback:
- Use `new Error(msg, { cause: err })` to preserve original stack trace
- Restore `[void]` prefix for consistency with other errors in the package
- Add unit tests for getPrerenderPaths failure scenarios
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
Superseded by #16 — console.warn → throw change consolidated there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
collectPrerenderPathsto throw a hard error instead ofconsole.warnwhengetPrerenderPathsfails to resolveIf a user explicitly exports
getPrerenderPathsand it fails (e.g. unresolved virtual module, missing alias), the build should fail with a clear error — not silently skip the page and produce missing HTML files.🤖 Generated with Claude Code