Repository navigation
fix(config): name the unknown field when a task config doesn't parse - #815
Merged
wan9chi merged 3 commits intoOct 19, 2026
Merged
Conversation
A mistyped task setting such as `cache: { outputs: [...] }` failed with
"data did not match any variant of untagged enum UserTaskDefinition".
Deserialize `UserTaskDefinition` and `UserCacheConfig` by value type so
the error of the form the user wrote is shown instead.
Refs voidzero-dev/vite-plus#2635
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Replace the hand-written `Visitor` impls for `UserTaskDefinition` and `UserCacheConfig` with `serde_untagged::UntaggedEnumVisitor`. Error messages are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
wan9chi
approved these changes
Oct 19, 2026
wan9chi
left a comment
wan9chi
left a comment
Member
There was a problem hiding this comment.
Thank you! I pushed to simplify a little bit with serde-untagged.
This was referenced Oct 19, 2026
cursor Bot
added a commit
to voidzero-dev/vite-plus
that referenced
this pull request
Oct 21, 2026
Bumps vite-task from `9ba4cc9` to `8db455e`. Changelog: voidzero-dev/vite-task@9ba4cc9...8db455e#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed ## Breaking change adapted fspy no longer reports a bitset of access modes on each path. Each tracked operation is its own `PathAccess` (`Read`, `Write`, `ReadWrite`, or `ReadDir`). `vp_command` combines the operations that touch the same workspace-relative path into the existing `AccessMode` set, so the JavaScript `run_command` result is unchanged. ## User-facing vite-task changes - A mistyped task setting now fails with an error that names the field, instead of `data did not match any variant of untagged enum UserTaskDefinition` (voidzero-dev/vite-task#815). - `vp run` no longer panics on scripts that contain non-ASCII characters, and no longer cuts those commands off where it displays them (voidzero-dev/vite-task#861). - Reinstalling with another pnpm version no longer changes the cache fingerprint of `node_modules/.modules.yaml`; only whether the file exists is hashed (voidzero-dev/vite-task#850). - Cached tasks on Linux and macOS no longer abort when a program passes `-1` as a directory descriptor, and concurrent syscalls in tracked programs no longer overflow the stack (voidzero-dev/vite-task#862, voidzero-dev/vite-task#854). Docs are unchanged. These are fixes to existing behavior, and the guides do not describe the old error text or the `.modules.yaml` fingerprint. ## Validation - `cargo check --workspace --all-features --all-targets --locked` - `cargo clippy -p vp_command -p vite-plus-cli --all-targets --all-features -- --deny warnings` - `cargo test` for `vp_command`, `vp_error`, `vp_pm_cli`, `vp_js_runtime`, `vp_migration`, `vp_shared`, `vp_static_config`, `vite-plus-cli`, and `vp_global_cli` <div><a href="https://cursor.com/agents/bc-9c9cb178-3b56-4d68-9556-3028d946a3ec?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a href="https://cursor.com/automations/3a586a0e-cc2b-11f1-bec7-b2318963e0b6"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/view-automation-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/view-automation-light.png"><img alt="View Automation" width="141" height="28" src="https://cursor.com/assets/images/view-automation-dark.png"></picture></a> </div> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Charles Wang <wan9chi@users.noreply.github.com>
![https://cursor.com/assets/images/open-in-web-dark.png"><source](https://cursor.com/assets/images/open-in-web-dark.png"><source){kind=link}
![https://cursor.com/assets/images/open-in-web-light.png"><img](https://cursor.com/assets/images/open-in-web-light.png"><img){kind=link}
![https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a](https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a){kind=link}
![https://cursor.com/assets/images/view-automation-dark.png"><source](https://cursor.com/assets/images/view-automation-dark.png"><source){kind=link}
![https://cursor.com/assets/images/view-automation-light.png"><img](https://cursor.com/assets/images/view-automation-light.png"><img){kind=link}
![https://cursor.com/assets/images/view-automation-dark.png"></picture></a> </div](https://cursor.com/assets/images/view-automation-dark.png"></picture></a> </div){kind=link}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs voidzero-dev/vite-plus#2635
Motivation
A mistyped setting in a task, such as
cache: { outputs: ["dist/**"] }(the field isoutput), fails with an error that names neither the key nor what is accepted:UserTaskDefinitionandUserCacheConfigwere#[serde(untagged)], which discards each variant's own error. They now pick the variant from the value's type, so the real error comes through:Valid configs parse as before and
run-config.tsis unchanged. The error still doesn't name the task; that needs path tracking in the config loaders.The main report in the issue (a cache hit that doesn't restore files) is already fixed by #461.
AI-assisted with Claude Opus 5.5.