Repository navigation
Preserve Nushell file completion when fish is not installed - #3273
Closed
voidzero-bot[bot] wants to merge 1 commit into
Closed
voidzero-bot[bot] wants to merge 1 commit into
voidzero-bot[bot] wants to merge 1 commit into
Conversation
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://triagebot-fix-3272-viteplus-dev.voidzero-docs.workers.dev (commit cea3212)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
4 tasks done
Contributor
CLI artifact sizes (
|
| Artifact | Format | Base | PR | Change |
|---|---|---|---|---|
packages/cli/dist |
Directory total | 2.26 MiB | 2.26 MiB | 0 B (0.00%) |
packages/core/dist |
Directory total | 4.07 MiB | 4.07 MiB | 0 B (0.00%) |
| Combined package dist | Directory total | 6.34 MiB | 6.34 MiB | 0 B (0.00%) |
vp (Linux x64) |
Binary | 8.27 MiB | 8.27 MiB | 0 B (0.00%) |
vp (Linux x64) |
gzip -9 | 3.78 MiB | 3.78 MiB | +129 B (+0.00%) |
| NAPI (Linux x64) | Binary | 35.53 MiB | 35.53 MiB | 0 B (0.00%) |
| NAPI (Linux x64) | gzip -9 | 14.15 MiB | 14.15 MiB | 0 B (0.00%) |
vp (macOS ARM64) |
Binary | 5.39 MiB | 5.39 MiB | 0 B (0.00%) |
vp (macOS ARM64) |
gzip -9 | 3.21 MiB | 3.21 MiB | +87 B (+0.00%) |
| NAPI (macOS ARM64) | Binary | 42.30 MiB | 42.30 MiB | 0 B (0.00%) |
| NAPI (macOS ARM64) | gzip -9 | 18.28 MiB | 18.28 MiB | 0 B (0.00%) |
vp (Windows x64) |
Binary | 6.12 MiB | 6.12 MiB | 0 B (0.00%) |
vp (Windows x64) |
gzip -9 | 2.83 MiB | 2.83 MiB | +22 B (+0.00%) |
| NAPI (Windows x64) | Binary | 31.55 MiB | 31.55 MiB | 0 B (0.00%) |
| NAPI (Windows x64) | gzip -9 | 12.85 MiB | 12.85 MiB | -1 B (-0.00%) |
| Trampoline (Windows x64) | Binary | 13.50 KiB | 13.50 KiB | 0 B (0.00%) |
| Trampoline (Windows x64) | gzip -9 | 7.09 KiB | 7.09 KiB | -1 B (-0.01%) |
| Installer (Windows x64) | Binary | 4.68 MiB | 4.68 MiB | 0 B (0.00%) |
| Installer (Windows x64) | gzip -9 | 2.24 MiB | 2.24 MiB | -1 B (-0.00%) |
Collaborator
|
I have a replacement for this PR with a behavior test. It depends on #3267, so I will open it after #3267 merges. See #3272 (comment) for details. |
Member
|
@naokihaba I’ll close this PR for now. The newly added issue diagnostic assistant automatically submits PRs, and I’ll close any unreasonable ones first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Nushell
env.nugenerated byvp env setupdelegatesvp/vprcompletions to Fish. If Fish is not onPATH, the completer fails. Nushell 0.116 now treats a failing parameter completer as having no suggestions, so pressing Tab aftervpshows nothing instead of falling back to the default file completion.Add a guard that checks for a usable
fishbinary and returnsnullwhen it is missing. Returningnulllets Nushel