Activity

1. naokihaba

   self-assigned this

   on Oct 29, 2026
2. naokihaba

   added

   pending triage

   on Oct 29, 2026
3. naokihaba

   added the

   Bug

   issue type on Oct 29, 2026
4. voidzero-bot commented on Oct 29, 2026

   

   voidzero-botBot

   on Oct 29, 2026

   More actions

   • Reproduced: Yes
   • Exploration: Yes — View branch
   • Unit Test: Yes — crates/vp_global_cli/src/commands/env/setup.rs
   • Priority: P2: Has Workaround. This only happens when Nushell 0.116 is used without fish on PATH; users can restore rich completions by installing fish manually. It is annoying because Tab shows nothing, but it does not break installs or builds.

   The generated env.nu defines nu-complete vp and nu-complete vpr in crates/vp_global_cli/src/commands/env/setup.rs. Both helpers run ^fish --command ... to delegate to Fish completions, and when fish is absent the external command fails. Nushell 0.116 treats a failing parameter completer as an explicit empty list, so the built-in file completion fallback no longer runs.

   I found a potential fix for this issue. Adding if (%which fish | %is-empty) { return null } at the top of both completers makes Nushell decline the custom completion and fall back to file completions. The guard only handles a missing fish binary; it intentionally does not wrap the ^fish call in try/catch, so real failures when fish is installed are still surfaced. A regression test in crates/vp_global_cli/src/commands/env/setup.rs checks that both the % sigil and Legacy renderings include the guard.

   Full Triage Report

   Triage Report: gh-3272

   Issue Summary

   Title: Nushell 0.116: vp and vpr completion shows nothing when fish is not installed

   When the Nushell env.nu generated by vp env setup is loaded, the parameter completers for vp and vpr run ^fish to delegate to Fish completion. If fish is not on PATH, the external command fails. Nushell 0.116 changed behavior so that a failing parameter completer returns an empty suggestion list instead of falling back to file completions. Pressing Tab after vp therefore shows nothing.

   Environment

   • Repository: /home/runner/work/vite-plus/vite-plus
   • Branch: triagebot/fix-3272
   • vp (local checkout): vp v1.4.0
   • Node.js: v22.23.4
   • pnpm: 12.11.2
   • OS: Ubuntu (GitHub Actions runner, x86_64)
   • Nushell under test: 0.116.1
   • fish: 3.7.0

   Reproduction

   With Nushell 0.116.1 and no usable fish binary:

   export VP_HOME=$(mktemp -d)
   export VP_SELF_SETUP_NO_MODIFY_PATH=1
   vp env setup --refresh
   cd "$VP_HOME"
   nu -n -c 'source env.nu; $env.PATH = ($env.PATH | where { not ($in | path join fish | path exists) }); which fish; "vp " | commandline complete'
   # empty list

   Control case with fish on PATH:

   nu -n -c 'source env.nu; which fish; "vp " | commandline complete | length'
   # 35

   Diagnosis

   • Affected file: crates/vp_global_cli/src/commands/env/setup.rs
   • Affected template: ENV_TEMPLATE_NU (lines ~954–1046), specifically:
     • def "nu-complete vp" [context: string] { ... }
     • def "nu-complete vpr" [context: string] { ... }
   • Root cause: Both completers directly execute ^fish --command ... without checking whether fish is installed. When it is absent, the completer fails and Nushell 0.116 returns an empty list.
   • Suggested fix: Add if (%which fish | %is-empty) { return null } at the start of both completers. The % prefix is automatically stripped for Nushell versions older than 0.112.1 by the existing % → nu_syntax.builtin_prefix() substitution.

   Verification

   The Nushell Book recommends returning null from a parameter completer to decline and let the default completion source answer. The reporter’s proposed guard matches this idiom. Wrapping the entire ^fish call in try { ... } catch { null } was intentionally avoided so that real completion failures when fish is installed are not silently hidden.

   Verdict: bug
   Confidence: high

   Fix

   Changed file

   • crates/vp_global_cli/src/commands/env/setup.rs
     • Added if (%which fish | %is-empty) { return null } to nu-complete vp.
     • Added if (%which fish | %is-empty) { return null } to nu-complete vpr.
     • Added assertions to test_render_env_content_nu_syntax to verify both the % sigil and Legacy renderings include the guard in both completers.

   Regression test

   Updated crates/vp_global_cli/src/commands/env/setup.rs:

   let sigil = render_env_content(EnvShell::Nu, &config, NuSyntax::BuiltinSigil);
   assert!(
       sigil.contains("if (%which fish | %is-empty) { return null }"),
       "got: {sigil}"
   );
   assert_eq!(
       sigil.matches("if (%which fish | %is-empty) { return null }").count(),
       2,
       "guard should appear in both vp and vpr completers, got: {sigil}"
   );
   
   let legacy = render_env_content(EnvShell::Nu, &config, NuSyntax::Legacy);
   assert!(
       legacy.contains("if (which fish | is-empty) { return null }"),
       "got: {legacy}"
   );
   assert_eq!(
       legacy.matches("if (which fish | is-empty) { return null }").count(),
       2,
       "guard should appear in both vp and vpr completers, got: {legacy}"
   );

   Validation

   1. Unit tests:

      cargo test -p vp_global_cli commands::env::setup::tests

      Result: 36 passed.

   2. Lint/format:

      cargo fmt --all -- --check
      cargo clippy -p vp_global_cli --all-targets -- -D warnings

      Result: both passed.

   3. End-to-end with generated env.nu:

      • Built the global CLI release binary.
      • Installed it into a fresh VP_HOME.
      • With Nushell 0.116.1 and fish removed from PATH, commandline complete for "vp " returned file completions.
      • With fish on PATH, the same command returned 35 Fish-backed completions.
      • Re-ran the setup with Nushell 0.116.1 on PATH to exercise the % sigil path; the generated env.nu contained if (%which fish | %is-empty) { return null } and also fell back to file completions.

   Result

   • fixed: true
   • The original reproduction now returns file completions instead of an empty list when fish is absent, while full completions continue to work when fish is present.

   4. Full crate test suite:

      cargo test -p vp_global_cli

      Result: 543 passed; 0 failed.

   This report was made by an LLM. The analysis may be wrong, and the potential fix might not work, but is intended as a starting point for exploring the issue.

   I've opened a pull request with this fix: #3273
5. voidzero-bot

   added

   triage: fix verified

   - P2: has workaroundAffects specific usage and has a straightforward workaround (priority)Affects specific usage and has a straightforward workaround (priority)

   on Oct 29, 2026
6. naokihaba commented on Oct 29, 2026

   

   naokihaba

   on Oct 29, 2026

   CollaboratorAuthor

   More actions

   I have a fix with a behavior test on my fork:

   naokihaba/vite-plus@fix/nushell-completer-input...fix/nushell-completion-without-fish

   It depends on #3267, so I will open the PR after #3267 merges. Compared with #3273, it adds the guard once in the shared nu-complete vp fish helper. It also adds a snapshot test that runs Nushell without fish, and it updates shell_integration_cwd_templates.md. I suggest that we close #3273 when I open the PR.
7. naokihaba

   added a commit that references this issue on Oct 29, 2026

   fix(env): fall back to file completion in Nushell without fish

   ...

   This issue will close once commit f075433 is merged into the 'main' branch.

   f075433
8. fengmk2

   closed this as completedin #3276on Oct 30, 2026
9. fengmk2

   added a commit that references this issue on Oct 30, 2026

   fix(env): fall back to file completion in Nushell without fish (#3276)

   ...

   This issue will close once commit b567b23 is merged into the 'main' branch.

   b567b23