Skip to content

clippy: disable assert_is_empty lint - #15026

Merged
cakebaker merged 1 commit into
uutils:mainfrom
cakebaker:clippy_disable_lint
Oct 2, 2026
Merged

cakebaker merged 1 commit into
uutils:mainfrom
cakebaker:clippy_disable_lint

Conversation

@cakebaker

Copy link
Copy Markdown
Contributor

This PR disables the assert_is_empty lint introduced with Rust 1.99 as there are concerns about its usefulness: #14472 (comment) and #15022 (comment) .

As for me, I'm torn: something like assert_eq!(x, "") is an improvement whereas something like assert_eq!(x, [] as [_; 0]) is not.

@cakebaker
cakebaker force-pushed the clippy_disable_lint branch from 6a7b226 to eb0063e Compare October 2, 2026 07:28
@codspeed

codspeed Bot commented Oct 2, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 9.16%

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 391 untouched benchmarks
⏩ 54 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation three_39_bit_primes 533 ms 685.9 ms -22.3%
⚡ Simulation five_38_bit_primes 1.8 s 1.7 s +6.21%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing cakebaker:clippy_disable_lint (eb0063e) with main (61a3e74)

Open in CodSpeed

Footnotes

  1. 54 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Congrats! The gnu test tests/id/setgid is no longer failing!

@cakebaker
cakebaker merged commit 92c7eb5 into uutils:main Oct 2, 2026
190 of 192 checks passed
@cakebaker
cakebaker deleted the clippy_disable_lint branch October 2, 2026 08:34
@cakebaker

Copy link
Copy Markdown
Contributor Author

I merged this PR myself to bring the CI back to green. And it's trivial to reverse if we decide to want to enable the lint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant