chore: fix clippy issues in rust v1.99 - #15022
eduardomourar wants to merge 1 commit into
Conversation
c7482ae to
f883c9c
Compare
Merging this PR will degrade performance by 13.36%
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing 
Footnotes
|
|
GNU testsuite comparison: |
| let (c, a, i) = extract_negative_modes(["--", "-r", "file"].iter().map(OsString::from)); | ||
| assert_eq!(c, None); | ||
| assert_eq!(a, ["--", "-r", "file"]); | ||
| assert!(i.is_empty()); |
There was a problem hiding this comment.
I like previous one. Can we disable the clippy?
There was a problem hiding this comment.
Me too. We can disable a particular clippy rule globally, but you would not have consistency (as both mechanisms would be allowed). My suggestion is to follow the default config from clippy in this case assert_is_empty.
|
@eduardomourar The clippy errors should now have been addressed, and |
|
If I ignore the
|
|
I'm not aware of any Clippy issues failing the build. |
|
@eduardomourar In general, please use separate commits per lint for this type of PR. |
This branch has not been deployed
3 participants
Fixes #14916
Resolves clippy lints surfaced by the stable toolchain update: redundant closures around
map_err, mergedcfg(not(any(...)))attributes, andis_empty/assert!replaced withassert_eq!/assert_ne!where clippy preferred it.No functional changes.