Conversation
Collaborator
|
why, |
Collaborator
|
Oh |
Collaborator
|
|
Contributor
Author
|
This script is used by uudoc. So we cannot rely on runner provided tools (even on bash and sed, but kept currently).
|
Collaborator
|
Relates to #9581. |
Collaborator
|
Sorry, I don't see the logic in replacing |
Contributor
Author
|
jaq was already used in freebsd CI as symlink since jq has dependency on oniguruma package which will be removed from freebsd's repo soon.
I just switched it to direct file path since show-utils does not use jq.
|
oech3
force-pushed
the
show-utils
branch
2 times, most recently
from
September 29, 2026 14:05
b380aa8 to
ca78ee8
Compare
xtqqczze
reviewed
Sep 29, 2026
| echo "WARN: missing \`jq\` (install with \`sudo apt install jq\`); falling back to default (only fully cross-platform) utility list" 1>&2 | ||
| echo "$default_utils" | ||
| if test "$*";then | ||
| _args=("$@") |
Collaborator
There was a problem hiding this comment.
By the way, in POSIX sh, arrays are undefined (see SC3030), although this script already requires Bash, so this doesn't introduce an additional portability concern.
Collaborator
That's no longer the case. The deprecation was removed because there are still many consumers of oniguruma, and they are not expected to move away from it anytime soon. See FreshPorts. |
oech3
marked this pull request as draft
October 1, 2026 14:07
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.