Skip to content

Revert "freebsd.yml: fix warning" - #14961

Open
xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:GH14488
Open

xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:GH14488

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Use jq instead of jaq in freebsd workflows.

As of 2026-09-23, the deprecation for oniguruma was removed. See FreshPorts:

devel/oniguruma: Remove DEPRECATED line because there are many consumers

and consumers are not getting off oniguruma any time soon.

Reverts #14488.
Conflicts with #14947.

@oech3

oech3 commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

This should NOT close #14947 .
The script is can be used on the system missing jq, not only on the CI. It is also serious for reproducibility of the result.

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Congrats! The gnu test tests/id/setgid is no longer failing!

@xtqqczze

Copy link
Copy Markdown
Collaborator Author

The script is can be used on the system missing jq, not only on the CI. It is also serious for reproducibility of the result.

Sorry, I may be misunderstanding the issue here. The script installs jq using pkg install, so could you please clarify what you mean by the script being used on systems without jq?

@oech3

oech3 commented Sep 30, 2026 via email

Copy link
Copy Markdown
Contributor

@xtqqczze

xtqqczze commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator Author

I mean the script that was changed in .github/workflows/freebsd.yml.

@oech3

oech3 commented Sep 30, 2026 via email

Copy link
Copy Markdown
Contributor

@oech3

oech3 commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Do we need to revert this just for famous command name? Reverting reduces 2 lines, but it is also done at #14947

@xtqqczze

xtqqczze commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator Author

@xtqqczze

xtqqczze commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator Author

Do we need to revert this just for famous command name?

I'd rather use the same command everywhere for consistency. For example, jq is available on all GitHub Actions runners and on every version of macOS. I don't see a strong reason to use jaq solely on FreeBSD.

@oech3

oech3 commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

OK. Would you merge this by yourself? Then I rebase my PR.

@xtqqczze
xtqqczze requested a review from cakebaker October 1, 2026 13:59
@xtqqczze

xtqqczze commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator Author

OK. Would you merge this by yourself? Then I rebase my PR.

OK, could you please mark #14947 as draft for now? Alternatively, if you prefer, you can rebase on this PR (to include 91874f2) and I’ll close it.

@oech3

oech3 commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

marked as draft

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants