Skip to content

tests: don't pipe input into commands that exit before reading it #14431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cakebaker merged 1 commit into from
Sep 8, 2026
Merged

tests: don't pipe input into commands that exit before reading it #14431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/by-util/test_numfmt.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ fn test_unit_size_hyphen_leading_as_separate_arg() {
for opt in ["--from-unit", "--to-unit"] {
new_ucmd!()
.args(&[opt, "-1"])
.pipe_in("5\n")
.pipe_in("")
.fails()
.stderr_contains("invalid unit size: '-1'");
}
Expand All @@ -196,7 +196,7 @@ fn test_unit_hyphen_leading_as_separate_arg() {
for opt in ["--from", "--to"] {
new_ucmd!()
.args(&[opt, "-x"])
.pipe_in("5\n")
.pipe_in("")
.fails()
.stderr_contains("invalid argument '-x' for '--");
}
Expand Down
4 changes: 2 additions & 2 deletions tests/by-util/test_sort.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1894,7 +1894,7 @@ fn test_separator_attached_equals_double() {
// `-t==` selects the two-character separator `==`, which GNU rejects.
new_ucmd!()
.args(&["-t==", "-k", "2"])
.pipe_in("a=b=c\n")
.pipe_in("")
.fails()
.stderr_contains("separator must be exactly one character long: '=='");
}
Expand All @@ -1904,7 +1904,7 @@ fn test_separator_attached_equals_multi_char() {
// `-t=a` selects the two-character separator `=a`, which GNU rejects.
new_ucmd!()
.args(&["-t=a", "-k", "2"])
.pipe_in("a=b=c\n")
.pipe_in("")
.fails()
.stderr_contains("separator must be exactly one character long: '=a'");
}
Expand Down
Loading