tests: don't pipe input into commands that exit before reading it - #14431
Merged
Merged
Conversation
sort -t== and numfmt --from-unit -1 fail while parsing arguments, so they never read stdin. The pipe_in thread races that exit and intermittently fails the test with "failed to write to stdin of child: Broken pipe". These four tests do not need input at all, so pipe nothing.
|
Binary size comparison: |
|
GNU testsuite comparison: |
Contributor
|
Thanks! |
This was referenced Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sort -t==,sort -t=aandnumfmt --from-unit -1/--from -xfail while parsing their arguments, so they never read stdin. Thepipe_inthread writes into a pipe whose read end is already closed, and the test fails withfailed to write to stdin of child: Broken pipe (os error 32)— intermittently, depending on which side wins.I hit this on my own test in #14400, then saw the same failure on
test_sort::test_separator_attached_equals_multi_charin an unrelated PR, so it is a class rather than one test.None of these four tests need input, so they now pipe nothing.
To find the rest of the class I temporarily added a sleep before the write in
pipe_in, which turns the race into a deterministic failure, and ran the whole suite: these four are the only ones. That probe is not part of this PR.