Repository navigation
Conversation
Contributor
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryRestores staged API specifications when resuming a scan.
samirhvbr explicitly states that staging remains temporary and that missing staged files must be restored or the user must start a fresh scan. This limit is intentional. Review was based on code inspection; tests and live sandboxes were not run. Reviews (1) · Last reviewed commit: "fix(cli): restore staged API specificati..." · Reviewed by Greptile |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resuming an API-spec scan kept the saved
/workspace/api-specs/...paths but omitted their sandbox source. This restores the per-run staged specifications for both bind-mount and copy-based backends. Resume reuses those files, including duplicate-name disambiguation, rather than replacing them from changed originals or refetching a collection. A missing staged file now produces an actionable resume error before launch.Closes #1619.
Validation on upstream
6b7ae2e, Python 3.12.14 with frozen dependencies and an isolated HOME:git diff --checkpass.make check-allreaches the existing Pyright failures: 936 diagnostics after the patch versus 941 on the unchanged base, with no new diagnostics (compared by file, rule and message, ignoring shifted line numbers).No live Docker sandbox, LLM, Postman service or target scan was exercised. Staging remains temporary: if the scan's staged copy has been removed, it must be restored or the user must start a fresh scan. This change does not recreate it from a potentially changed source.