Skip to content

fix(cli): restore API specifications when resuming scans - #44

Open
samirhvbr wants to merge 2 commits into
masterfrom
feat/backport-api-spec-resume
Open

samirhvbr wants to merge 2 commits into
masterfrom
feat/backport-api-spec-resume

Conversation

@samirhvbr

@samirhvbr samirhvbr commented Oct 29, 2026 •

Copy link
Copy Markdown
Owner

Resuming an API-spec scan preserved /workspace/api-specs/... in its saved target metadata but omitted the sandbox source. This backports usestrix/strix#1621, addressing upstream issue #1619, onto fork master at 8aa0791e.

Resume restores the existing per-run staged files for bind-mount and copy-based backends. Changed or deleted original inputs do not replace the staged snapshot; duplicate filenames retain their original disambiguation. A missing staged file produces an actionable error before launch. The fork's assessment, identity-context, network-policy, test-pause and diff-scope resume checks are preserved.

Validation with Python 3.12.14, frozen dependencies, isolated HOME and LITELLM_MODE=PRODUCTION:

  • Both new regression tests fail against unchanged fork production code: the resumed source list is empty, and a missing staged file is silently accepted.
  • After the backport, 182 tests pass across API specs, CLI resume/targets, source mounting, workspace files, inputs and session entries.
  • The additional fork-policy suites report 160 passed, 1 failed. The failure is a timeout in test_n_one_parks_real_agent_loops_under_stop_policy_without_duplicate_calls; it also fails on the unchanged fork base and passes when rerun alone on this branch. No pause-policy code was changed.
  • Ruff lint/format, Mypy on both changed source files, Bandit and git diff --check pass.
  • Repository Pyright: 1,254 existing diagnostics, compared with 1,259 on the unchanged fork base. No new diagnostics by file, rule and message, ignoring shifted line numbers.
  • bin/pr-watch 1621 reports the upstream review and CI awaiting maintainer approval; local checks do not establish remote CI success.

FORK.md records the contribution as proposed for master. No version bump, tag, release or merge is included. Full-suite, live Docker, LLM, Postman-service and target-scan validation were not performed. Staging remains temporary: a removed snapshot must be restored, or a fresh scan started.

Remote CI: the workflow could not start its jobs because GitHub reports that the account is locked due to a billing issue. This is not a passing CI result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant