Repository navigation
Conversation
Contributor
[Medium impact] The change affects the cloud CLI's session scope-update workflow. The PR appears safe to merge, with a small improvement needed in the recovery message. Findings
Fix with agent prompt### Issue 1
strix/interface/cloud/session.py:137
The recovery message recommends `strix cloud session show`, but that command only prints the profile and scope count in a terminal. After a failed local save, users cannot see which permissions actually changed. Recommend `strix cloud session scopes` or `strix cloud session show --show-scopes` instead.
```suggestion
"`strix cloud session scopes`; fix local storage and rerun the same "
```
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.SummaryReports a failed local save after a successful scope change without raising a traceback.
Reviews (1) · Last reviewed commit: "fix(cloud): report scope metadata persis..." · Reviewed by Greptile |
| http.CloudError( | ||
| "the platform updated the session scopes, but the local session " | ||
| f"metadata could not be stored: {exc}. Check the active scopes with " | ||
| "`strix cloud session show`; fix local storage and rerun the same " |
Contributor
There was a problem hiding this comment.
Recovery command hides permissions
The recovery message recommends strix cloud session show, but that command only prints the profile and scope count in a terminal. After a failed local save, users cannot see which permissions actually changed. Recommend strix cloud session scopes or strix cloud session show --show-scopes instead.
Suggested change
| "`strix cloud session show`; fix local storage and rerun the same " | |
| "`strix cloud session scopes`; fix local storage and rerun the same " |
Prompt To Fix With AI
This is a comment left during a code review.
Path: strix/interface/cloud/session.py
Line: 137
Comment:
**Recovery command hides permissions**
The recovery message recommends `strix cloud session show`, but that command only prints the profile and scope count in a terminal. After a failed local save, users cannot see which permissions actually changed. Recommend `strix cloud session scopes` or `strix cloud session show --show-scopes` instead.
```suggestion
"`strix cloud session scopes`; fix local storage and rerun the same "
```
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a successful
PATCH /cli/session, saving the local auth record can fail with a filesystem error.session scopes set --jsonthen raises a traceback even though the remote access changed, leaving callers without structured recovery information.Handle the local write failure as a partial success: return exit 1 with
scopes_updated: trueandlocal_record_updated: false, explain that the remote change succeeded, and point tostrix cloud session scopesand retrying after fixing local storage. Preserve the existing auth record and the stateless token-override behavior.Closes #1608.
Validation on macOS/Apple Silicon, Python 3.12.14, against upstream
98e3df14:OSError("disk full")after one successful synthetic PATCH.git diff --checkpasses.make check-allcurrently stops at 940 pre-existing Pyright errors; no claim of a green full repository gate.All HTTP responses are synthetic. No live cloud account, permission update, paid scan or LLM call was used.