Repository navigation
fix(cloud): report local save failure after session scope update - #39
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
cloud session scopes setsuccessfully updates the server but cannot save the refreshed local session record, the command currently escapes with a traceback. This makes the server-side outcome ambiguous to both people and automation.Backport of usestrix#1614, including its review follow-up, to fork
masterat8aa0791e. Related issue: usestrix#1608.The local save failure now returns a controlled error (exit 1) with
scopes_updated: trueandlocal_record_updated: false. Human guidance points tostrix cloud session scopes, which shows the effective scopes. External tokens supplied through a flag or environment variable remain stateless.FORK.mdtracks the contribution.Validation on the fork with Python 3.12.14, frozen dependencies and an isolated HOME/environment:
OSError("disk full").pytest -q tests/test_cloud*.py: 325 passed.git diff --checkpassed.A real cloud session and the complete repository suite were not exercised. The remote PATCH is simulated in the tests. Version stamping and release remain part of the merge/delivery procedure.
Remote CI: GitHub Actions run could not start its jobs because the account is locked due to a billing issue. No remote validation was performed.