Skip to content

docs: note jj fallback in repo inference review convention - #327

Open
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/fix-docs/docs-note-jj-fallback-in-repo-inference-review-con-590477
Open

docs: note jj fallback in repo inference review convention#327
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/fix-docs/docs-note-jj-fallback-in-repo-inference-review-con-590477

Conversation

@detail-app

@detail-app detail-app Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

REVIEW.md told reviewers that new commands accepting a repo positional should fall back to inferring owner/repo from the git remote. After jj support was added to src/utils/vcs.rs, this convention is stale — a contributor following it would omit the jj fallback and write code inconsistent with the new pattern (and with the "git or jj remote (origin)" help text now advertised by detail bugs/detail rules/detail scans). Updated to mention jj and point at src/utils/vcs.rs for the canonical implementation.

Introduced by commit 9b815d7 (@dbt, #324)


Doc Drift PRs can be configured here.


Open in Devin Review

Summary by cubic

Update REVIEW.md to state that repo inference should fall back to the git or jj remote and point to src/utils/vcs.rs for the canonical logic. Aligns review guidance with CLI help for detail bugs, detail rules, and detail scans.

Written for commit 6e5fac9. Summary will update on new commits.

Review in cubic

@detail-app
detail-app Bot requested a review from sachiniyer August 3, 2026 15:45
@aviator-app

aviator-app Bot commented Aug 3, 2026

Copy link
Copy Markdown

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR is not ready to merge (currently in state pending): this PR has not been approved.

Pending Status Checks

  • ✅ 7 tests passing!

See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@detail-app
detail-app Bot deployed to integration-tests August 3, 2026 15:45 Active

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant