docs: note jj fallback in repo inference review convention - #327
Open
detail-app[bot] wants to merge 1 commit into
Open
docs: note jj fallback in repo inference review convention#327detail-app[bot] wants to merge 1 commit into
detail-app[bot] wants to merge 1 commit into
Conversation
Current Aviator status
This PR is not ready to merge (currently in state pending): this PR has not been approved. Pending Status Checks
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REVIEW.md told reviewers that new commands accepting a
repopositional should fall back to inferringowner/repofrom the git remote. After jj support was added tosrc/utils/vcs.rs, this convention is stale — a contributor following it would omit the jj fallback and write code inconsistent with the new pattern (and with the "git or jj remote (origin)" help text now advertised bydetail bugs/detail rules/detail scans). Updated to mention jj and point atsrc/utils/vcs.rsfor the canonical implementation.Introduced by commit 9b815d7 (@dbt, #324)
Doc Drift PRs can be configured here.
Summary by cubic
Update REVIEW.md to state that repo inference should fall back to the git or jj remote and point to
src/utils/vcs.rsfor the canonical logic. Aligns review guidance with CLI help fordetail bugs,detail rules, anddetail scans.Written for commit 6e5fac9. Summary will update on new commits.