main: export BLACKSMITH_STICKYDISK_KEY for downstream build attribution - #127
Closed
piob-io wants to merge 1 commit into
Closed
main: export BLACKSMITH_STICKYDISK_KEY for downstream build attribution#127piob-io wants to merge 1 commit into
piob-io wants to merge 1 commit into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker_build_historiesattribution is broken for v2 custom cache keys: the backend looks up the sticky disk entity bystickydisk_key = repo_name(the v1 default), so builds behind a customcache-keyget pinned to the old repo-named entity (observed on Hero-Apps-Dev/HeroNet, where all builds still attribute to theHero-Apps-Dev/HeroNetentity while the builder actually runs onheronet/app).This PR is the first link in the fix: after a successful sticky disk setup, the action exports the configured key so later steps can report it:
The variable is only exported when the Blacksmith builder setup succeeds (not on local-builder fallback), so a reported key always identifies a real Blacksmith sticky disk.
Companion PRs:
build-push-actionreads this variable and sends it asstickydisk_keyin the build-start report; the web backend prefers it in the entity lookup, falling back torepo_namefor v1 clients.Link to Devin session: https://app.devin.ai/sessions/6ee33a7c3e5848e9a39d85439b161082
Requested by: @piob-io
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.