reporter: report the actual sticky disk key for build attribution - #150
Closed
piob-io wants to merge 1 commit into
Closed
reporter: report the actual sticky disk key for build attribution#150piob-io wants to merge 1 commit into
piob-io wants to merge 1 commit into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Superseded: we're avoiding action changes. Attribution is now fixed platform-side via storage-agent expose events (useblacksmith/storage-agent#605) + vm_id lookup in the backend (useblacksmith/web#10682). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker_build_historiesattribution is broken for setup-docker-builder v2 custom cache keys: the backend resolves the sticky disk entity bystickydisk_key = repo_name, so builds behind a customcache-keyget attributed to the stale repo-named entity (observed on Hero-Apps-Dev/HeroNet after their key split).reporter.tsnow includes the actual builder key in both the build-start payload and failure reports:BLACKSMITH_STICKYDISK_KEYis exported by setup-docker-builder v2 after a successful sticky disk setup (useblacksmith/setup-docker-builder#127); v1 jobs don't set it, so the value falls back to the repo name — matching current behavior. The web backend companion PR prefersstickydisk_keyin the entity lookup with the samerepo_namefallback.dist/regenerated vianpm run build.Link to Devin session: https://app.devin.ai/sessions/6ee33a7c3e5848e9a39d85439b161082
Requested by: @piob-io
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled. (Staging)Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.