Repository navigation
Conversation
A build needed docker or a buildkitd on the caller's machine, since the CLI could only build with a local buildkit. --remote <url> builds on the build service instead, which pushes the image. The project directory, the registry logins, --secret and --ssh reach the builder through a buildkit session. Signed-off-by: Dragos Gheorghioiu <dragosg@unikraft.com>
Reviewed-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.com> Approved-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.com>
The build service creates the account's builder on the first remote build, and the CLI could not create it beforehand, nor inspect or free its cache without deleting it. Add unikraft buildkit create, du and prune. create makes the builder with the service's sizes through x/buildkit's Platform.Create, unless it exists, and works in js too. du and prune wake it to call buildkit's DiskUsage and Prune. Bump x/buildkit for Platform.Create. Signed-off-by: Dragos Gheorghioiu <dragosg@unikraft.com>
Reviewed-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.com> Approved-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.com>
Signed-off-by: Dragos Gheorghioiu <dragosg@unikraft.com>
instance exec exited with 130 for every signal that ended the command, since x/shell folded the plugin's negated signal into it. Exit with 128 plus the signal instead, as instance shell does. Signed-off-by: Dragos Gheorghioiu <dragosg@unikraft.com>
Reviewed-by: Alex-Andrei Cioc <andrei.cioc@unikraft.io> Approved-by: Alex-Andrei Cioc <andrei.cioc@unikraft.io>
So that every push to prod-staging opens a PR to prod-stable. Signed-off-by: Justin Chadwell <justin@unikraft.com>
The server now redirects a tag to the digest held in a file of that name, the way an origin pins one. Both the tag and the digest are inspected, copied and run. Signed-off-by: Justin Chadwell <justin@unikraft.com>
unikraft buildkit created and pruned the builder on the platform itself, so it had to know the build service's instance names and sizes, and it does not find the builders the service now names remote-builder-<name>. Rename it to unikraft builder, which asks the build service at --remote to create a builder, or to report or prune its cache. Signed-off-by: Dragos Gheorghioiu <dragosg@unikraft.com>
Reviewed-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.com> Approved-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.com>
Reviewed-by: Omar El Khatib <omar@unikraft.com> Approved-by: Omar El Khatib <omar@unikraft.com>
Member
Author
|
Superseded by #595, which the new promote workflow opened (unikraft-cloud/x#592). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked until follow-ups from:
Which @dragosgheorghioiu is working on.