Repository navigation
feat(cmd): Manage builders through the build API - #594
Merged
dragosgheorghioiu merged 1 commit intoOct 30, 2026
Merged
dragosgheorghioiu merged 1 commit into
dragosgheorghioiu merged 1 commit into
Conversation
dragosgheorghioiu
marked this pull request as draft
October 30, 2026 14:53
dragosgheorghioiu
force-pushed
the
dragosg/tool-1740-restructure-the-clis-buildkit-subcommands
branch
from
October 30, 2026 14:58
504fe7e to
2d30fb2
Compare
unikraft buildkit created and pruned the builder on the platform itself, so it had to know the build service's instance names and sizes, and it does not find the builders the service now names remote-builder-<name>. Rename it to unikraft builder, which asks the build service at --remote to create a builder, or to report or prune its cache. Signed-off-by: Dragos Gheorghioiu <dragosg@unikraft.com>
dragosgheorghioiu
force-pushed
the
dragosg/tool-1740-restructure-the-clis-buildkit-subcommands
branch
from
October 30, 2026 15:09
2d30fb2 to
58caa6e
Compare
dragosgheorghioiu
marked this pull request as ready for review
October 30, 2026 15:09
Contributor
Author
|
this will unblock #592 |
craciunoiuc
approved these changes
Oct 30, 2026
craciunoiuc
left a comment
craciunoiuc
left a comment
Contributor
There was a problem hiding this comment.
All good here. Thanks!
Reviewed-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.com>
Approved-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.com>
dragosgheorghioiu
deleted the
dragosg/tool-1740-restructure-the-clis-buildkit-subcommands
branch
October 30, 2026 15:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unikraft buildkitcreated and pruned the builder on the platform itself, so it had to know the build service's instance names and sizes (buildkit-default, 4 vCPUs, 4096 MiB, a 20480 MiB cache).Rename it to
unikraft builder, whosecreate,duandpruneeach make one call to the build service at--remote(or$UNIKRAFT_BUILD_URL) through the go-sdk build client, for the builder named by an optional[name]that defaults todefault.--metrogoes away, since the service decides the metro. There is nobuildkitalias: it only shipped in thev0.7.0-staging.2and.3prereleases.TestBuilderreplacesTestBuildkitand runs against the service atUNIKRAFT_X_TEST_BUILD_URL, like the remote build test.The commands work in the js CLI too, since unikraft-cloud/go-sdk#305 builds the client for js.
Closes: TOOL-1740