Skip to content

Update to t8code v4.0.0-26-10 - #321

Merged
sloede merged 5 commits into
mainfrom
bg/t8code-26-9
Oct 13, 2026
Merged

sloede merged 5 commits into
mainfrom
bg/t8code-26-9

Conversation

@benegee

@benegee benegee commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

Update to t8code version currently pulled in via Trixi.jl.

This is bit difficult to track. Unlike #307 the latest T8code.jl release was not breaking for Trixi.jl, so it gets pulled in here as well, which however leads to an inconsistent state w.r.t. the t8code version we compile manually in CI.

Should we introduce compat bounds on T8code.jl or t8code_jll.jl?

@codecov

codecov Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.11%. Comparing base (9a350ac) to head (0bf2244).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #321   +/-   ##
=======================================
  Coverage   96.11%   96.11%           
=======================================
  Files          25       25           
  Lines        1260     1260           
  Branches       74       74           
=======================================
  Hits         1211     1211           
  Misses         45       45           
  Partials        4        4           
Flag Coverage Δ
unittests 96.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@benegee
benegee requested a review from sloede October 1, 2026 13:59
@benegee benegee changed the title Update to t8code v4.0.0-26-09 Update to t8code v4.0.0-26-10 Oct 2, 2026
@sloede
sloede enabled auto-merge (squash) October 13, 2026 06:28

@sloede sloede left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sloede

sloede commented Oct 13, 2026

Copy link
Copy Markdown
Member

Should we introduce compat bounds on T8code.jl or t8code_jll.jl?

This might make sense. It depends on how much hassle - i.e., need for manual intervention - it gives you because of version mismatches.

@sloede
sloede merged commit 83724cb into main Oct 13, 2026
13 checks passed
@sloede
sloede deleted the bg/t8code-26-9 branch October 13, 2026 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants