add fuctions to load env file and replace env specific values - #60
Closed
dallinjsevy wants to merge 1 commit into
Closed
add fuctions to load env file and replace env specific values#60dallinjsevy wants to merge 1 commit into
dallinjsevy wants to merge 1 commit into
Conversation
phalestrivir
requested changes
Jul 9, 2026
phalestrivir
requested changes
Jul 13, 2026
phalestrivir
left a comment
phalestrivir
left a comment
There was a problem hiding this comment.
I realized we should probably have tests for all these functions, especially after looking more closely at the replaceEnvSpecificValues one. We want to have tests to verify the replacing strategies, as well as reading in a JSON file, work as expected.
dallinjsevy
force-pushed
the
feature/add-replaceEnvSpecifiValues
branch
from
July 23, 2026 20:30
cff963f to
2a0c892
Compare
phalestrivir
requested changes
Jul 24, 2026
phalestrivir
requested changes
Aug 5, 2026
phalestrivir
left a comment
phalestrivir
left a comment
There was a problem hiding this comment.
Looks good, but we still need tests for State.test.ts and ExportImportUtils.test.ts
dallinjsevy
force-pushed
the
feature/add-replaceEnvSpecifiValues
branch
from
August 6, 2026 16:54
14e8367 to
1066705
Compare
phalestrivir
approved these changes
Aug 11, 2026
phalestrivir
left a comment
phalestrivir
left a comment
There was a problem hiding this comment.
Squash your commits, rebase with main, and then submit the PR to Rockcarver
dallinjsevy
force-pushed
the
feature/add-replaceEnvSpecifiValues
branch
from
August 13, 2026 19:33
f9c903c to
156379d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add replaceEnvScpecific values for fr-config manager placeholder support