Feature/config manager pull telemetry - #61
Conversation
d99f32e to
fbb458c
Compare
phalestrivir
left a comment
There was a problem hiding this comment.
After making your changes, make sure to run npm run build, and you will see some changes in the Help.ts file which you need to commit.
After making your changes, run npm run lint:fix, and you will see some changes that need to be committed as well.
The other thing is to add tests for TelemetryOps, since currently we don't have any tests for any of the functions. In order to have tests for this, you are going to need to also implement delete functions in the API so you can delete test data. You will definitely need this since you can only have one exporter in the tenant at a time while running the tenant, and we'll want to test both importing splunk and otlp exporters.
|
I forgot to mention in my PR review, but we should also add a function for Also, add a function for We probably won't need all these for config-manager, but we may as well add them since they are pretty simple to implement. |
0d7692f to
93cdad9
Compare
phalestrivir
left a comment
There was a problem hiding this comment.
Make sure to run npm run build again, when I ran it locally there were some changes that were missing from the Help.ts file.
After you do that, squash your commits, rebase with main again (since there are some new changes that I just synced to main this morning), and then make the PR against Rockcarver once you've verified the tests are still passing.
phalestrivir
left a comment
There was a problem hiding this comment.
Actually, I think we do need one more change. We should update ConfigOps to handle exporting telemetry, since it should support it (currently we don't export telemetry in Frodo). Now that you have the export/import functions implemented, we should update ConfigOps.ts to export and import it as part of the full export/import commands.
3528b9f to
d0c4915
Compare
phalestrivir
left a comment
There was a problem hiding this comment.
I updated it to do the full export/import with telemetry in the most recent commit. I rebased with main as well, so you will need to run git reset --hard origin/feature/config-manager-pull-telemetry on your local version of the branch to get the changes.
Feel free to squash the commits, but I wouldn't create the PR until the pull command is ready. We are going to need to update the pull command PR to update the config export/import tests to pass with telemetry since they currently aren't working for telemetry. Once we have the CLI PR ready against Rockcarver we can submit this one as well.
d0c4915 to
393cff3
Compare
393cff3 to
d0c4915
Compare
add api and ops functions for config-manager telemetry commands