Repository navigation
Send ESC DEL for Alt+Backspace and BS for Ctrl+Backspace - #167
Merged
tomlm merged 3 commits intoOct 13, 2026
Merged
Conversation
The legacy generator mapped Backspace to DEL whatever the modifiers, so a shell deleted one character for Alt+Backspace. Mirrors xterm.js Keyboard.ts, case 8.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The implementation matches the documented behavior and covers all changed combinations.
0 open findings
What changed in this PR
Updates legacy Backspace encoding to match xterm.js and shell expectations.
Changes:
- Sends BS for Ctrl+Backspace and prefixes Alt combinations with ESC.
- Adds coverage for Alt, Ctrl, and Ctrl+Alt combinations.
| File | Description |
|---|---|
KeyboardInputGenerator.cs |
Implements modifier-aware Backspace encoding. |
KeyboardInputTests.cs |
Tests the new legacy sequences. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #166.
KeyboardInputGeneratormappedKey.Backspaceto DEL whatever the modifiers, so a shell deleted one character for Alt+Backspace and could not tell Ctrl+Backspace from a plain one. This mirrors the xterm.js rule (Keyboard.ts,case 8):^Hwhen Ctrl is held, DEL otherwise, and an ESC prefix when Alt is held.Backspace, Alt\x7f\x1b\x7fBackspace, Control\x7f\x08Backspace, Control + Alt\x7f\x1b\x08Only the legacy path changes; the kitty encoding of the same chords was already correct. Two tests added in
KeyboardInputTests; the whole suite passes.