Repository navigation
Wait for the hit test in the touch drag tests, and close system dialogs in the Android check - #152
Merged
Conversation
…gs in the Android check The touch tests waited a fixed number of frames before pressing the moved grip, which a slow compositor on Xvfb did not always draw in time; they now wait until the pointer hits the grip. The Android check closes an emulator's "isn't responding" dialog of a system app with Wait instead of failing on it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The push build of avalonia12 after #151 failed in two checks that have nothing to do with that change; both were flaky.
The touch drag test of the tour editor (a second finger on the resize grip) failed on Linux with "The pointer hits SinglePointerThumb, not Canvas": after the grip moved, the test waited a fixed number of frames, and the compositor on Xvfb had not drawn the new place yet, so the second press hit the old one. The tests that press a grip after it moved now wait until the pointer actually hits it.
The Android start check failed with "The home page did not show" although the Gallery was there: the emulator showed "Pixel Launcher isn't responding" on top of it. The check now closes such a dialog with Wait and dumps again, with a test for it.
Locally the two touch tests passed five runs in a row, the whole runtime suite passes, and the script tests too.