Repository navigation
Turn off the system's error dialogs in the Android check - #153
Merged
Merged
Conversation
A slow emulator showed "Pixel Launcher isn't responding" over the Gallery and the dialog took the tap on a theme, so the check failed although the Gallery worked. The check now hides the error dialogs, also those of apps in the background, before it starts the Gallery.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Android start check failed again on the push build after #152: the emulator showed "Pixel Launcher isn't responding" just as the check tapped Cupcake in the theme list, so the tap landed in the dialog, the theme stayed Dark and the check reported that Cupcake did not apply. The Gallery itself was fine.
The check now sets
hide_error_dialogsandanr_show_background=0before it installs and starts the Gallery, so the system closes a hanging app quietly instead of putting a dialog over the screen. Closing such a dialog with Wait stays in as a fallback.I checked on a local API 35 emulator that both settings are taken; whether they hide the dialog I could not reproduce locally, since a launcher that stops responding only happens on the slow CI emulator.