Repository navigation
Run the Browser Gallery publish steps in the workflows again - #151
Merged
Merged
Conversation
The release workflow checks out the branch it is asked to build and then ran the local publish-browser-gallery action from that checkout, which code scanning reports as cache poisoning. The steps are inline again in ci.yml and _build-gallery.yml, and the action is gone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code scanning flagged the Browser job of
_build-gallery.ymlafter #150 (alert 69, cache poisoning): the release workflow checks out the branch it is asked to build and then ran the localpublish-browser-galleryaction from that checkout.This puts the three steps (wasm workload, publish, wwwroot check) back into
ci.ymland_build-gallery.ymldirectly, as they were before #150, still with the SDK fromglobal.json, and removes the action. That also drops the note that a release branch has to contain the action.