util/async: avoid blocking Append on Exec cancellation

[zyguan]

Fix #2033

RunLoop.Append could block indefinitely when racing with cancellation of a waiting RunLoop.Exec.

Append changes the state from StateWaiting to StateIdle under the mutex, then sends a notification through the
unbuffered ready channel after releasing the mutex. If Exec selected ctx.Done() and returned before receiving that
notification, the Append caller was left blocked. When invoked from an async batch response callback, this could stop
the batch receive loop from retiring the request and processing later responses on the same stream.

Changes:

• Make the cancellation path distinguish between a run loop that is still waiting and one for which an Append has
  already committed to sending a notification.
• Consume the committed notification before returning from Exec, ensuring the notifying Append can complete.
• Document the notification handshake and its single-Exec safety invariant.
• Add regression coverage for the cancellation race, queued-task preservation, and subsequent Exec behavior.
• Make the concurrent Exec test deterministic by synchronizing on the first executor entering StateRunning.

Summary by CodeRabbit

• Bug Fixes

  • Improved run loop behavior when execution is cancelled while another task is being added.
  • Prevented potential hangs during concurrent task scheduling.
  • Ensured the run loop remains usable for subsequent executions after cancellation.

• Tests

  • Added coverage for cancellation and concurrent task execution scenarios.

[coderabbitai]

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 3c99195d-bc94-4eb0-87e8-c53ec08e3c49

📥 Commits

Reviewing files that changed from the base of the PR and between ccf4025 and 7bc9b16.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

📝 Walkthrough

Walkthrough

RunLoop.Exec now handles cancellation races with Append by consuming pending notifications when necessary. Tests add deterministic coverage for cancellation unblocking and concurrent execution outcomes.

Changes

RunLoop cancellation

Layer / File(s)	Summary
Cancellation notification handling util/async/runloop.go	Documents the state/ready handshake and updates Exec to consume a pending notification when cancellation races with Append.
Concurrency regression coverage util/async/runloop_test.go	Adds cancellation coverage ensuring Append unblocks and subsequent execution succeeds, and replaces timing-based concurrent execution checks with channel-coordinated assertions.

Estimated code review effort: 3 (Moderate) | ~20 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the RunLoop.Append/Exec cancellation fix.
Linked Issues check	✅ Passed	The changes address #2033 by preventing Exec cancellation from strand­ing Append and add regression coverage for the race.
Out of Scope Changes check	✅ Passed	All changes stay within util/async and directly support the cancellation-race fix and tests.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[zyguan]

@D3Hunter @cfzjywxk @lcwangchao PTAL

[zyguan]

CI failed because #2048 introduced a flacky test TestSnapshotRuntimeStatsAsyncBatchGetMultipleRegionsCoverage. It has been fixed in #2074 , so we can merge #2074 first.

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2026-07-28 09:23:29.37267314 +0000 UTC m=+1915195.408768196: ☑️ agreed by cfzjywxk.
• 2026-09-20 07:12:37.903380569 +0000 UTC m=+534803.841038162: ☑️ agreed by lcwangchao.

[ti-chi-bot]

@coderabbitai[bot]: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, coderabbitai[bot], lcwangchao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [cfzjywxk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lcwangchao]

/cherry-pick release-nextgen-20251011

[ti-chi-bot]

@lcwangchao: The label(s) /release-nextgen-20251011 cannot be applied, because the repository doesn't have them.

Details

In response to this:

/cherry-pick release-nextgen-20251011

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

@lcwangchao: new pull request created to branch release-nextgen-20251011: #2094.

Details

In response to this:

/cherry-pick release-nextgen-20251011

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[lcwangchao]

/cherry-pick release-nextgen-202603

[ti-chi-bot]

@lcwangchao: The label(s) /release-nextgen-202603 cannot be applied, because the repository doesn't have them.

Details

In response to this:

/cherry-pick release-nextgen-202603

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

@lcwangchao: new pull request created to branch release-nextgen-202603: #2095.

Details

In response to this:

/cherry-pick release-nextgen-202603

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.