store: update client-go to fix batch response cancellation race - #71679
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe Changesclient-go revision update
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix · Severity of issue fixed: Medium Suggested reviewers: Merge Risk: ⚪ Minimal · up to The dependency update is localized, and no concrete regression is evidenced. The change appears ready to merge. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 2 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Linked Issues checkExplanation PR Resolution Add the required TiDB regression test for the cancellation race and the follow-up request. Add investigation documentation with the Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 golangci-lint (2.13.2)level=error msg="Running error: context loading failed: failed to load packages: failed to load packages: failed to load with go/packages: context deadline exceeded" Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the version line, Comment |
|
@wfxr: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, wfxr, you06 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Chao Wang <cclcwangchao@hotmail.com>
97d56e5 to
f98e54c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-nextgen-20251011 #71679 +/- ##
=============================================================
Coverage ? 71.8291%
=============================================================
Files ? 1835
Lines ? 494004
Branches ? 0
=============================================================
Hits ? 354839
Misses ? 115751
Partials ? 23414
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
/retest |
58325ec
into
pingcap:release-nextgen-20251011
What problem does this PR solve?
Issue Number: close #71677
Problem Summary:
The pinned client-go version predates the fix for a cancellation race that can block
RunLoop.Appendand a TiKVBatchCommandsreceive loop. See tikv/client-go#2033.What changed and how does it work?
Update client-go from
e91097b8e3f9to5f06ec672bb6, the latestrelease-nextgen-20251011commit, which contains the backport of tikv/client-go#2034 (tikv/client-go#2094). Regenerate the Bazel dependency metadata and module checksums.Check List
Tests
Validation:
make bazel_prepare;go mod verify. The client-go backport includes its own regression tests.Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
Summary by CodeRabbit