Repository navigation
ci: block merge while checks are still running - #945
Merged
Merged
Conversation
`#check-failure = 0` means "nothing is red", which is true while checks are yellow -- the gate went green 2m21s before CI finished on both commits of #942. Adding `#check-pending = 0` makes it mean "all green". The comment claiming this deadlocks is unverified: it is Mergify's own documented pattern, and merge protections report pending rather than resolving when a pending condition is present. #832 more likely deadlocked on the named anchors over path-filtered workflows. If it does deadlock, the next PR hangs and this reverts in one line. Fixes #943
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #943.
success_conditions: - "#check-failure = 0" + - "#check-pending = 0"#check-failure = 0means "nothing is red", which is true while checks are yellow. The gate went green 2m21s before CI finished on both commits of #942. Adding the pending condition makes it mean "all green".Names no checks, so path-filtered workflows stay maintenance-free.
Testing it
Mergify reads config from the default branch, so this does nothing until merged. After merging, open any PR: the protection should sit pending while checks run, then go green.
If it deadlocks instead — the claim in the comment this removes — revert this one line and fall back to restoring pr-monitor (Option B in #943).
E2E Verification
N/A - CI configuration only
Generated by Claude Code