Repository navigation
Revert "ci: block merge while checks are still running" - #947
Closed
thekevinbot wants to merge 1 commit into
Closed
thekevinbot wants to merge 1 commit into
thekevinbot wants to merge 1 commit into
Conversation
`#check-pending = 0` deadlocks merge protections, as the comment it removed said it would. Confirmed on #946: after all 91 checks completed, Mergify sat pending with Waiting for: [ ] #check-pending = 0 Waiting checks: `` <- empty The only pending check is Mergify's own, which it cannot name. Branch protection requires that check, so nothing can merge until this is reverted. Reopens #943. The fix is pr-monitor (Option B), not a condition tweak.
This was referenced Aug 14, 2026
Collaborator
Author
|
Superseded by #950, which deletes .mergify.yml entirely — no point reverting one rule inside a file that's going away. The deadlock this documented ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#check-pending = 0deadlocks merge protections, exactly as the comment #945 removed said it would. Confirmed on #946 — after all 91 checks completed, Mergify sat pending:The "waiting checks" list is empty. The only pending check is Mergify's own, which it cannot name, so the count never reaches zero.
My evidence for doubting the original comment (discussion #2184, the pending-events changelog) described
pull_request_rules, where Mergify produces no check of its own. It does not carry over tomerge_protections.Restores the previous behaviour, including its known defect: the gate is vacuously green before CI starts (#943, reopened). The remaining fix is pr-monitor — Option B — not a condition tweak.
E2E Verification
N/A - CI configuration only