Skip to content

Revert "ci: block merge while checks are still running" - #947

Closed
thekevinbot wants to merge 1 commit into
mainfrom
claude/943-revert-pending-condition
Closed

thekevinbot wants to merge 1 commit into
mainfrom
claude/943-revert-pending-condition

Conversation

@thekevinbot

@thekevinbot thekevinbot commented Aug 14, 2026 •

Copy link
Copy Markdown
Collaborator

⚠️ This will need an admin merge. The gate it reverts deadlocks every PR, including this one.

#check-pending = 0 deadlocks merge protections, exactly as the comment #945 removed said it would. Confirmed on #946 — after all 91 checks completed, Mergify sat pending:

🟠 All CI green — Waiting for:  [ ] #check-pending = 0
    Waiting checks: ``.          ← empty
                    [X] #check-failure = 0

The "waiting checks" list is empty. The only pending check is Mergify's own, which it cannot name, so the count never reaches zero.

My evidence for doubting the original comment (discussion #2184, the pending-events changelog) described pull_request_rules, where Mergify produces no check of its own. It does not carry over to merge_protections.

Restores the previous behaviour, including its known defect: the gate is vacuously green before CI starts (#943, reopened). The remaining fix is pr-monitor — Option B — not a condition tweak.

E2E Verification

N/A - CI configuration only


`#check-pending = 0` deadlocks merge protections, as the comment it removed
said it would. Confirmed on #946: after all 91 checks completed, Mergify sat
pending with

  Waiting for: [ ] #check-pending = 0
  Waiting checks: ``          <- empty

The only pending check is Mergify's own, which it cannot name. Branch
protection requires that check, so nothing can merge until this is reverted.

Reopens #943. The fix is pr-monitor (Option B), not a condition tweak.
@thekevinbot

Copy link
Copy Markdown
Collaborator Author

Superseded by #950, which deletes .mergify.yml entirely — no point reverting one rule inside a file that's going away. The deadlock this documented (#check-pending = 0 counting Mergify's own check, so it never reaches zero) is real and worth keeping in the record; the fix is dropping Mergify, not tuning it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants