Repository navigation
Sort a wide directory's chunks while it is read - #1547
Merged
Merged
Conversation
thekevinbot
marked this pull request as ready for review
October 20, 2026 12:28
This was referenced Nov 2, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1546
Refs #1461
A directory wider than one 8192-entry chunk was read whole, then sorted on one thread. Now, once a second chunk arrives, a thread of its own sorts each chunk while the next is read; the sorted chunks are then split at names sampled from the first chunk and merged on every core (a stable sort over each run's already-sorted shares). A directory of one chunk is sorted as before, with no thread. Only
listing.rschanges;scanner.rsandtree_walk.rsare untouched.Measurements
1.2M-entry flat tree (
./docsand the root, every 50th file a dotfile), release builds, paired runs on a loaded host. Output md5 identical tomainfor./docs,./*,./,./docs/*,./**/*.md, and a 74k-file deep tree.PENDING
E2E Verification
PENDING
Changelog / Migrations
<root>/<pkg>/changelog.d/for each changed package (or:skip-changelogtrailer on a commit with reason)<root>/<pkg>/migrations.d/for each changed package (every subsection but Summary_None._when nothing breaks)