Repository navigation
test: hold ./docs/ to the fastest native - #1568
Open
thekevinbot wants to merge 2 commits into
Open
thekevinbot wants to merge 2 commits into
thekevinbot wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1482
./docs/already runs under the fastest native on currentmain(the wide-directory work in #1515, #1522, #1528, #1535, #1547 closed the gap), so no code change is needed. This holds the./docs/symlink case to the fastest native instead offind, so the gap cannot come back unnoticed.Measured on
main05880bb (paired harness, 5 screen + 15 measured pairs, host load 6-28 from concurrent agents):findThe issue measured 1.25-1.5x. The native side of this case is ~0.04s, so the ratio is sensitive to the startup subtraction under heavy load.
E2E Verification
packages/python/e2e-attestations/<branch>.jsonreceipt written ifpackages/pythonchanged (just e2e-attest-python)packages/ts/e2e-attestations/<branch>.jsonreceipt written ifpackages/tschanged (just e2e-attest-ts)uv run maturin develop --release,cargo build --release -p dirsql --features cli,testing-conventions e2e attest 'uv run python -m pytest tests/e2e/glob_speed_symlink_test.py -x -q -s'Changelog / Migrations
packages/python/tests/; exempt.