Repository navigation
test: fix main's lib-test compile (scan_glob_rows visit argument) - #1527
Merged
Merged
Conversation
This was referenced Oct 16, 2026
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1526
mainfails to compile its Rust lib tests. Two PRs merged around the same time: #1515 addedscan_glob_rows_makes_rows_of_a_wide_directory_on_many_threads, which callsscan_glob_rowswithout thevisitargument that another merged PR added. The test now collects rows throughvisit. Its assertions are unchanged.E2E Verification
N/A - test-only change. The receipts record a no-op (
testing-conventions e2e attest 'true') because the e2e-verify gate scopespackages/rust/src.Changelog / Migrations
Test only (
skip-changelog).