Skip to content

test: collect scan_glob_rows rows through its visit callback - #1529

Closed
thekevinbot wants to merge 3 commits into
mainfrom
bot/1525-scan-rows-test-1016
Closed

thekevinbot wants to merge 3 commits into
mainfrom
bot/1525-scan-rows-test-1016

Conversation

@thekevinbot

@thekevinbot thekevinbot commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes #1525

main @860d7ef7 fails to compile the dirsql lib tests (Rust CI red: Lint, Unit, Integration, Windows, coverage floor): the wide-directory test from #1515 calls scan_glob_rows with the pre-#1513 signature. This updates the test to collect rows through the visit callback. Test-only.

Red: main's own Rust CI run for 860d7ef fails on exactly these E0061/E0599 errors.

E2E Verification

  • Ran e2e suites locally for every affected SDK
  • Python SDK e2e: N/A (test-only change; no e2e test exercises it). Receipt is a deliberate no-op.
  • TypeScript SDK e2e: N/A (test-only change). Receipt is a deliberate no-op.
  • Rust core e2e (if applicable): pass
  • packages/python/e2e-attestations/<branch>.json receipt written if packages/python changed
  • packages/ts/e2e-attestations/<branch>.json receipt written if packages/ts changed
  • Command(s) run: cargo test --workspace --features cli; testing-conventions e2e attest 'true' in each package
  • Result summary: 2067 passed, 0 failed

Changelog / Migrations

  • skip-changelog line on a commit with reason (inline test only; no observable change)
  • Migration fragment: N/A (skip-changelog)

@thekevinbot

Copy link
Copy Markdown
Collaborator Author

Duplicate of #1527 (same one-test compile fix for main).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

main fails to compile tests: scan_glob_rows test from #1515 predates #1513's visit argument

1 participant