Repository navigation
test: collect scan_glob_rows rows through its visit callback - #1529
Closed
thekevinbot wants to merge 3 commits into
Closed
thekevinbot wants to merge 3 commits into
thekevinbot wants to merge 3 commits into
Conversation
Collaborator
Author
|
Duplicate of #1527 (same one-test compile fix for main). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1525
main @860d7ef7 fails to compile the
dirsqllib tests (Rust CI red: Lint, Unit, Integration, Windows, coverage floor): the wide-directory test from #1515 callsscan_glob_rowswith the pre-#1513 signature. This updates the test to collect rows through thevisitcallback. Test-only.Red: main's own Rust CI run for 860d7ef fails on exactly these E0061/E0599 errors.
E2E Verification
packages/python/e2e-attestations/<branch>.jsonreceipt written ifpackages/pythonchangedpackages/ts/e2e-attestations/<branch>.jsonreceipt written ifpackages/tschangedcargo test --workspace --features cli;testing-conventions e2e attest 'true'in each packageChangelog / Migrations
skip-changelogline on a commit with reason (inline test only; no observable change)