Repository navigation
Start per-table hooks while the walk is still running - #1502
Merged
Merged
Conversation
8 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1483
Per-table
on_filehooks now start on the first path the startup walk matches and are fed paths as it finds them, instead of after the walk ends. Hook-spawn latency and path copying overlap the walk. Output is unchanged; row order across invocations was already unspecified.Measurements (65k-note vault,
GROUP BY status, release binary, A/B interleaved vs PR A head)taskset -c 8-15(load ~16): median 103.5 -> 87.2ms.taskset -c 8-11: median 150 -> 132ms.Decisions
Red/green
Red run 38190251372 (Unit tests job):
prepare_starts_a_per_table_hook_while_the_walk_is_still_runningfailed atassert!(hook_saw_it_mid_walk.get()), the asserted reason.E2E Verification
uv run python -m pytest tests/e2e/jsonl_parse_speed_test.py tests/e2e/frontmatter_parse_speed_test.py tests/e2e/on_file_query_test.py tests/e2e/query_contract_test.py -x -q: 14 passed (python receipt).pnpm test:e2e: passed (ts receipt).cargo test -p dirsql --lib: 1152 passed. Gated preflight: 0 failing.