Repository navigation
perf: rerun a per-table hook over known paths on the calling thread - #1516
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1514
A per-table hook rerun over paths that are already known and fit one invocation runs on the calling thread again, without counting CPUs. Since the streaming dispatcher (#1502), every watch rerun spawned a dispatcher thread and a worker thread and read the cgroup CPU files before spawning the hook, which put the Python e2e
watch_speed_testover its 1.1x bar. Paths still arriving from a walk keep the streaming pool.Paired local measurement, 600 alternating samples vs
inotifywait(median per-pair ratio, loaded host):watch_speed_teston this PR, five runs: medians 0.889, 0.976, 1.062, 1.042, 0.935, all passing.Changelog / Migrations
<root>/<pkg>/changelog.d/for each changed package (or:skip-changelogtrailer on a commit with reason)<root>/<pkg>/migrations.d/for each changed package (every subsection but Summary_None._when nothing breaks)E2E Verification
cargo test --lib on_file::pass)packages/python/e2e-attestations/<branch>.jsonreceipt written ifpackages/pythonchanged (just e2e-attest-python)packages/ts/e2e-attestations/<branch>.jsonreceipt written ifpackages/tschanged (just e2e-attest-ts)testing-conventions e2e attest 'uv run python -m pytest tests/e2e/{watch_speed,on_file_query,fanout,declared_table_name,query_contract,server_speed,jsonl_parse_speed,frontmatter_parse_speed,use_case_notebook,use_case_transcripts,sigint_interrupt}_test.py -x -q';just e2e-attest-ts