Repository navigation
Warn when a config table's glob matches no files - #1366
Merged
Merged
Conversation
skip-changelog: test-only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1232. Step 4 of 4. Stacked on #1363 (base
claude/1232-config-anchor); #1363 stacks on #1360.A config
[[table]]whose glob matches no files printsdirsql: table 'sessions': glob 'projects/*/*.jsonl' matched no files under <anchor>to stderr. Exit code unchanged; path-tables and programmatic tables do not warn.Red commit: 4cd2795, test
cli_zero_match_warning(expected the stderr line, got empty stderr).Changelog / Migrations
packages/{rust,python,ts}/changelog.d/packages/{rust,python,ts}/migrations.d/E2E Verification
packages/python/e2e-attestations/claude-1232-zero-match.json. Impacted files only (every e2e file that loads a config, since config tables can now emit a stderr warning):fanout,capture_collision,declared_table_name,extension_package,plugin_discovery,use_case_notebook,on_file_query,use_case_transcripts,plugin_extension_discovery,use_case_join,use_case_dossier,sigint_interrupt,query_contract-- 32 passed. Command:testing-conventions e2e attest 'uv run python -m pytest tests/e2e/<impacted files> -x -q'just e2e-attest-ts: passcargo test -p dirsql --features cli -- --test-threads=1withulimit -n 65536: passglob = "projects/*/*.jsonl"run from another directory returned both rows, identical to bash globstar; the empty table printed the warning, exit 0