Repository navigation
docs: a glob page pinned by a conformance table - #1378
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1259
Retargeted to
mainafter the #1258 stack merged.What
docs/reference/glob.md: why bash globstar, a fixture tree, a conformance table, the divergences with reasons, anchoring, edge cases. Linked from the sidebar,path-tables.mdandconfig.md(whose glob-rule text now points at it).packages/rust/tests/glob_conformance.rsparses the fixture and table out ofglob.mdand runs every row as a path-table (realdirsqlbinary,HOMEset for~/) and, minus the leading./, as a configglob. The page is the data, so it cannot drift.scripts/glob-conformance.sh checkruns the same rows throughbash -O globstar -O nullglob(dotglob off). Rows with no divergence tag must equal bash's output after three filters, one per divergence (files only,node_modulesunless spelled, gitignored*.log). A tagged row must differ from raw bash, so a stale tag fails. CI never calls bash.config_glob_parity.rsonly compares the two dirsql surfaces, so this is a new file.Red / green
Red run 37418784848:
glob_conformancefailed on./[z.mdand./**/.*, behavior absent from the base then. Both are onmainnow; the test passes here.E2E Verification
Docs and a test only; no
packages/rust/srcchange, so no receipts.cargo test -p dirsql --features cli --test glob_conformanceandscripts/glob-conformance.sh checkwere run.pnpm buildindocs/is clean.